dhmap: stop deploying development files to the web root - #439
Merged
Conversation
/opt/dhmap is symlinked to /var/www/html/dhmap and the whole repository is synced there recursively, with only .git excluded. So anything added to the repository becomes publicly readable, whether or not it has anything to do with serving the map. dhmap is gaining a test suite, which brings a test tree, a Makefile, npm manifests and CI configuration - none of it useful in production. Two of the excluded names matter beyond tidiness. Neither is committed, so neither should reach a puppetmaster checkout, but the cost of being wrong is uneven: local/ is where a real ipplan database is dropped during development, and publishing that would expose host addressing and network definitions; node_modules appears the moment anyone runs npm install in the checkout, and would sync several hundred megabytes into the web root. Excluding them here means the deploy no longer depends on those files merely happening to be absent.
AlexanderMalmstrom
approved these changes
Jul 28, 2026
AlexanderMalmstrom
left a comment
AlexanderMalmstrom
left a comment
Contributor
There was a problem hiding this comment.
Looks right to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/opt/dhmap is symlinked to /var/www/html/dhmap and the whole repository is synced there recursively, with only .git excluded. So anything added to the repository becomes publicly readable, whether or not it has anything to do with serving the map.
dhmap is gaining a test suite, which brings a test tree, a Makefile, npm manifests and CI configuration - none of it useful in production.
Two of the excluded names matter beyond tidiness. Neither is committed, so neither should reach a puppetmaster checkout, but the cost of being wrong is uneven: local/ is where a real ipplan database is dropped during development, and publishing that would expose host addressing and network definitions; node_modules appears the moment anyone runs npm install in the checkout, and would sync several hundred megabytes into the web root.
Excluding them here means the deploy no longer depends on those files merely happening to be absent.