speedtest v2 - #411
Merged
Merged
Conversation
Changed speedtest2 -> speedtestv2
Contributor
|
This PR should now be ready to merge. |
SoundGoof
commented
Mar 1, 2026
Removed apt-update part since puppet should handle that.
Fixed linting issue
Derive the served hostname from the node's FQDN instead of hardcoding speedtest2.event.dreamhack.se. This turns speedtest.conf into an ERB template so server_name and the certificate paths all render from @fqdn, matching how the apache and inspircd modules already do it. Certificates are issued on the puppetmaster and only copied down, so the cert resources now notify the nginx service - without that a renewed cert sits on disk while nginx keeps serving the old one. They also require Package['ssl-cert'], which owns the ssl-cert group they set as their group, and would otherwise fail on a freshly provisioned node. TLS config drops TLSv1/TLSv1.1 and the "ALL" cipher list in favour of nginx defaults, error logging is restored (access logging stays off on purpose, it skews the measurement), and the CORS headers are gone since the test is served directly rather than embedded from another origin. The web root is now purged so stale assets and nginx's own default files are cleaned up, and its mode drops to 0644 so the static assets are not world-executable; Puppet restores the execute bit on directories itself. Also removes hosted.html, which embedded an iframe from openspeedtest.com, and the .well-known/acme-challenge block, which pointed at the wrong root and could never have served a challenge from this host.
AlexanderMalmstrom
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.