feat: [ANDROSDK-2238] Analytics: respect configured start day in relative weekly period#2552
Merged
taridepaco merged 9 commits intodevelopfrom Feb 23, 2026
Merged
feat: [ANDROSDK-2238] Analytics: respect configured start day in relative weekly period#2552taridepaco merged 9 commits intodevelopfrom
taridepaco merged 9 commits intodevelopfrom
Conversation
refactor helper name
fix tests update api dump
vgarciabnz
reviewed
Feb 18, 2026
| } | ||
| } | ||
|
|
||
| override fun getWeekStart(): PeriodType { |
Member
There was a problem hiding this comment.
This is equivalent to the financialYear method, right? Shouldn't it be called getWeeklyPeriodType to be consistent?
|
|
||
| override fun generateRelativePeriods(relativePeriod: RelativePeriod): List<Period> { | ||
| val periodType = relativePeriod.getPeriodType(yearly.financialYearPeriodHelper) | ||
| val periodType = relativePeriod.getPeriodType(yearly.relativePeriodHelper) |
Member
There was a problem hiding this comment.
It is accessing the relativePeriodHelper through the yearly variable, but it is not just for yearly, it is for weekly as well. Maybe the helper shouldn't be located inside the yearly period generator?
| private val legendStore: LegendStore = koin.get() | ||
| private val clockProvider = ClockProviderFactory.createFixed() | ||
| private val financialYearPeriodHelper = FinancialYearPeriodHelperMock() | ||
| private val financialYearPeriodHelper = RelativePeriodHelperMock() |
Member
There was a problem hiding this comment.
There are many variables in the test classes that have not been renamed
|
vgarciabnz
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the required logic to use weeks starting in different days than Monday (depending on the corresponding System Settings parameter) for analytics.
Related task: ANDROSDK-2238