Skip to content

chore: yarn upgrade, node lts, lint warnings, code smells, cypress#3461

Draft
janhenrikoverland wants to merge 17 commits intomasterfrom
yarn-upgrade-and-node-lts
Draft

chore: yarn upgrade, node lts, lint warnings, code smells, cypress#3461
janhenrikoverland wants to merge 17 commits intomasterfrom
yarn-upgrade-and-node-lts

Conversation

@janhenrikoverland
Copy link
Copy Markdown
Collaborator

@janhenrikoverland janhenrikoverland commented Mar 23, 2026 •
edited
Loading

Spring cleaning:

  • yarn upgrade
  • node lts
  • fix lint warnings
  • fix code smells
Screenshot_2026-03-25_14-44-13 Screenshot_2026-03-25_15-17-09

@dhis2-bot
Copy link
Copy Markdown
Contributor

dhis2-bot commented Mar 23, 2026 •
edited
Loading

🚀 Deployed on https://pr-3461.data-visualizer.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify March 23, 2026 11:07 Inactive
@janhenrikoverland janhenrikoverland changed the title Yarn upgrade and node lts chore: yarn upgrade and node lts Mar 23, 2026
@dhis2-bot dhis2-bot temporarily deployed to netlify March 23, 2026 14:54 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 25, 2026 13:04 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 25, 2026 13:30 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 25, 2026 14:14 Inactive
@janhenrikoverland janhenrikoverland changed the title chore: yarn upgrade and node lts chore: yarn upgrade, node lts, lint warnings, code smells Mar 25, 2026
@dhis2-bot dhis2-bot temporarily deployed to netlify March 25, 2026 14:29 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 25, 2026 14:32 Inactive
@janhenrikoverland janhenrikoverland added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Mar 25, 2026
@cypress
Copy link
Copy Markdown

cypress bot commented Mar 25, 2026 •
edited
Loading

data-visualizer-app    Run #3146

Run Properties:  status check failed Failed #3146  •  git commit ac3268ae37 ℹ️: Merge 04e5a5aa41e439e3dd89bcc7146a2109130fa95a into 8f45e41bd5260b82ee4d5b156147...
Project data-visualizer-app
Branch Review yarn-upgrade-and-node-lts
Run status status check failed Failed #3146
Run duration 12m 30s
Commit git commit ac3268ae37 ℹ️: Merge 04e5a5aa41e439e3dd89bcc7146a2109130fa95a into 8f45e41bd5260b82ee4d5b156147...
Committer Jan Henrik Øverland
View all properties for this run ↗︎
Test results
Tests that failed  Failures 8
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 735
View all changes introduced in this branch ↗︎

Tests for review

Failed  dimensions/data.cy.js • 1 failed test • e2e-chrome-parallel-40-4

View Output Video

Test Artifacts
Data dimension > displays Event data items correctly Test Replay Screenshots Video
Failed  options/axes.cy.js • 1 failed test • e2e-chrome-parallel-40-4

View Output Video

Test Artifacts
Options - Auto-generated axis title > Multi items - single axis > config has vertical axis title "2 items and default black color Test Replay Screenshots Video
Failed  dimensions/data.cy.js • 1 failed test • e2e-chrome-parallel-42-4

View Output Video

Test Artifacts
Data dimension > displays Event data items correctly Test Replay Screenshots Video
Failed  options/axes.cy.js • 1 failed test • e2e-chrome-parallel-42-4

View Output Video

Test Artifacts
Options - Auto-generated axis title > Multi items - single axis > config has vertical axis title "2 items and default black color Test Replay Screenshots Video
Failed  visTypes/scatter.cy.js • 1 failed test • e2e-chrome-parallel-40-1

View Output Video

Test Artifacts
Scatter chart > works correctly (create, save, load, swap etc) Test Replay Screenshots Video

The first 5 failed specs are shown, see all 8 specs in Cypress Cloud.

Flakiness  options/cumulativeValues.cy.js • 1 flaky test • e2e-chrome-parallel-40-5

View Output Video

Test Artifacts
Options - Cumulative values > Interaction with other options (only for PT) > disables/enables Totals, Number type and Legend options when cumulativeValues is checked/unchecked Test Replay Screenshots Video
Flakiness  dimensions/data.cy.js • 1 flaky test • e2e-chrome-parallel-40-4

View Output Video

Test Artifacts
Data dimension > has correct initial state Test Replay Screenshots Video

@dhis2-bot dhis2-bot temporarily deployed to netlify March 27, 2026 23:03 Inactive
@janhenrikoverland janhenrikoverland changed the title chore: yarn upgrade, node lts, lint warnings, code smells chore: yarn upgrade, node lts, lint warnings, code smells, cypress Mar 27, 2026
@dhis2-bot dhis2-bot temporarily deployed to netlify March 27, 2026 23:15 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 27, 2026 23:36 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify March 27, 2026 23:50 Inactive
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 28, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dhis2-bot dhis2-bot temporarily deployed to netlify March 28, 2026 23:01 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janhenrikoverland @dhis2-bot