PdoDriver: check for misconfigured PDO connections resource (target 3.3.x and 4.0.x) by jkuchar · Pull Request #294 · dg/dibi

jkuchar · 2018-06-11T13:05:41Z

bug fix
BC break? no (as original behaviour should be considered as broken)

see #292

…catched

jkuchar · 2018-07-06T16:08:21Z

I do not know where to add tests for this. I dot see any PdoDriver unit test. Should I make one?

dg · 2018-07-08T14:50:12Z

If you want, create a test :)

jkuchar · 2018-07-19T14:27:15Z

~~I do not feel need to test this, however coveralls compalains in this PR. :)~~

One is never sure enough.

jkuchar · 2018-07-19T15:46:49Z

Any elegant way how to create PDO connection from database.ini? Maybe create PdoConnection and use reflection to access connection object? (do not want to replicate dibi connection factory)

jkuchar · 2018-07-20T08:39:02Z

tests/dibi/PdoDriver.providedConnection.phpt

+require __DIR__ . '/bootstrap.php';
+
+if($config['driver'] !== 'pdo') {
+	\Tester\Environment::skip('Only relevant for PDO driver.');


Wanted to use something like:

/** * @dataProvider ../databases.ini *, pdo */

However it looks like tester does not support anything like that.

Maybe use workaround like != foo, pdo

Sounds good!

dg · 2018-07-25T12:24:21Z

tests/dibi/PdoDriver.providedConnection.phpt

+
+// PDO error mode: warning
+Assert::exception(function() use ($config) {
+	($pdoConnection = new PDO($config['dsn']))->setAttribute(\PDO::ATTR_ERRMODE, \PDO::ERRMODE_EXCEPTION);


It should be PDO::ERRMODE_WARNING

dg · 2018-07-25T12:51:01Z

Great, thanks!

…rom PDO connection using Dibi internal factories)

jkuchar · 2018-07-25T13:06:17Z

tests/dibi/PdoDriver.providedConnection.phpt

+		->getProperty('connection');
+	$connectionProperty->setAccessible(TRUE);
+	$pdo = $connectionProperty->getValue($dibiDriver);
+	\assert($pdo instanceof PDO);


I have tried to rethink a little creation process of PDO connection. As it is quite complex I have delegated it back to \Dibi\Connection.

… unexpected exceptions in ODBC-PDO driver.

jkuchar changed the title ~~PdoDriver: check for misconfigured PDO connections resource~~ PdoDriver: check for misconfigured PDO connections resource Jun 11, 2018

jkuchar changed the title ~~PdoDriver: check for misconfigured PDO connections resource~~ PdoDriver: check for misconfigured PDO connections resource (target 3.3.x and 4.0.x) Jun 11, 2018

PdoDriver: check for misconfigured PDO connections resource

303d46f

jkuchar force-pushed the check-for-misiconfigured-pdo-resources branch from 838b540 to 303d46f Compare June 11, 2018 13:13

dg force-pushed the master branch 4 times, most recently from 1ac208e to 9840c31 Compare June 22, 2018 09:47

jkuchar added 2 commits July 6, 2018 17:49

PdoDriver: Only SILENT mode should be allowed as warning will not be …

c3c0240

…catched

conding standard

73fef35

PdoDriver: added tests for misconfigured PDO connection

f25bd10

jkuchar commented Jul 20, 2018

View reviewed changes

dg reviewed Jul 25, 2018

View reviewed changes

jkuchar added 3 commits July 25, 2018 14:26

fixed test for ERRMODE_WARNING

4e2725c

trying @dataProvider condition instead of skipping tests

add5836

fixup!

2af985f

PdoDriver test: refacted creation of PDO connection (now extracting f…

6c88563

…rom PDO connection using Dibi internal factories)

jkuchar commented Jul 25, 2018

View reviewed changes

jkuchar added 3 commits July 26, 2018 09:20

comment for test

52ab9ff

coding standard

9c00e44

PdoDriver: check for misconfigured connection earlier; it was causing…

9e178a5

… unexpected exceptions in ODBC-PDO driver.

dg force-pushed the master branch from 0fb63f3 to 0ad2dd7 Compare August 22, 2018 11:45

dg force-pushed the master branch from 7c22024 to 4b85f0a Compare September 13, 2018 01:28

dg merged commit e680866 into dg:master Sep 17, 2018

dg pushed a commit that referenced this pull request Sep 17, 2018

PdoDriver: check for misconfigured PDO connections resource (#294)

43e040a

dg pushed a commit that referenced this pull request Sep 17, 2018

PdoDriver: check for misconfigured PDO connections resource (#294)

aa7188e

dg pushed a commit that referenced this pull request Sep 17, 2018

PdoDriver: check for misconfigured PDO connections resource (#294)

6308b69

dg pushed a commit that referenced this pull request Sep 17, 2018

PdoDriver: check for misconfigured PDO connections resource (#294)

25d39e7

dg pushed a commit that referenced this pull request Sep 17, 2018

PdoDriver: check for misconfigured PDO connections resource (#294)

1f7da72

dg pushed a commit that referenced this pull request Sep 17, 2018

PdoDriver: check for misconfigured PDO connections resource (#294)

b063282

dg pushed a commit that referenced this pull request Sep 17, 2018

PdoDriver: check for misconfigured PDO connections resource (#294)

689597a

dg pushed a commit that referenced this pull request Sep 17, 2018

PdoDriver: check for misconfigured PDO connections resource (#294)

b406893

dg pushed a commit that referenced this pull request Sep 17, 2018

PdoDriver: check for misconfigured PDO connections resource (#294)

89987f0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

PdoDriver: check for misconfigured PDO connections resource (target 3.3.x and 4.0.x)#294

PdoDriver: check for misconfigured PDO connections resource (target 3.3.x and 4.0.x)#294
dg merged 11 commits intodg:masterfrom
grifart:check-for-misiconfigured-pdo-resources

jkuchar commented Jun 11, 2018 •

edited

Loading

Uh oh!

jkuchar commented Jul 6, 2018 •

edited

Loading

Uh oh!

dg commented Jul 8, 2018

Uh oh!

jkuchar commented Jul 19, 2018 •

edited

Loading

Uh oh!

jkuchar commented Jul 19, 2018 •

edited

Loading

Uh oh!

jkuchar Jul 20, 2018

Uh oh!

dg Jul 25, 2018

Uh oh!

jkuchar Jul 25, 2018

Uh oh!

dg Jul 25, 2018

Uh oh!

jkuchar Jul 25, 2018

Uh oh!

dg commented Jul 25, 2018

Uh oh!

jkuchar Jul 25, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

jkuchar commented Jun 11, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkuchar commented Jul 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dg commented Jul 8, 2018

Uh oh!

jkuchar commented Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkuchar commented Jul 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jkuchar Jul 20, 2018

Choose a reason for hiding this comment

Uh oh!

dg Jul 25, 2018

Choose a reason for hiding this comment

Uh oh!

jkuchar Jul 25, 2018

Choose a reason for hiding this comment

Uh oh!

dg Jul 25, 2018

Choose a reason for hiding this comment

Uh oh!

jkuchar Jul 25, 2018

Choose a reason for hiding this comment

Uh oh!

dg commented Jul 25, 2018

Uh oh!

jkuchar Jul 25, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jkuchar commented Jun 11, 2018 •

edited

Loading

jkuchar commented Jul 6, 2018 •

edited

Loading

jkuchar commented Jul 19, 2018 •

edited

Loading

jkuchar commented Jul 19, 2018 •

edited

Loading