Allow List#2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the SSRF-safe URL validation system by introducing an explicit allow-list mechanism, allowing callers to specify trusted origins or hostnames that should bypass SSRF checks. This is particularly useful for permitting known internal endpoints in secure environments. The changes also propagate this feature through the public API and its consumers.
SSRF-safe URL validation enhancements:
safeUrlAllowoption to theFetchInitinterface inlib/fetch.ts, enabling callers to specify a list of allowed origins or hostnames that bypass SSRF checks.lib/fetch.tsto pass thesafeUrlAllowoption to theisSafeUrlcheck for both the initial request and any redirects, ensuring consistent allow-list enforcement. [1] [2] [3]isSafeUrlfunction inlib/safeurl.tsto accept a newSafeUrlOptionsparameter, implementing logic to immediately allow URLs matching any entry in the provided allow-list.Public API updates:
SafeUrlOptionstype from the package entry point (index.ts) for external use.