feat(governance): expose get_maturity_modulation query endpoint#9879
Conversation
There was a problem hiding this comment.
Pull request overview
This PR exposes the Mission 70 “maturity modulation” value through the Governance canister’s public Candid interface so external tools/dashboards can query it.
Changes:
- Added
MaturityModulation,GetMaturityModulationRequest, andGetMaturityModulationResponsetoic-nns-governance-api. - Added
Governance::get_maturity_modulation()and a corresponding#[query] get_maturity_modulationcanister endpoint. - Updated
governance.didand added the required pb→api conversion forMaturityModulation.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| rs/nns/governance/src/pb/conversions/mod.rs | Adds pb→api From conversion for MaturityModulation. |
| rs/nns/governance/src/governance.rs | Adds a getter that exposes maturity modulation from heap state via API response type. |
| rs/nns/governance/canister/governance.did | Declares new request/response + MaturityModulation types and adds the new service method. |
| rs/nns/governance/canister/canister.rs | Implements the new public query endpoint that returns the modulation value. |
| rs/nns/governance/api/src/types.rs | Introduces new public API types for the query endpoint and payload. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
40e573b to
ebb47a9
Compare
0724790 to
9a31ba9
Compare
ebb47a9 to
83dc934
Compare
9a31ba9 to
a7108f0
Compare
83dc934 to
ee64f46
Compare
…name to duration_until_next_midnight_utc
ee64f46 to
5ff783e
Compare
5ff783e to
c1a9ced
Compare
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
1455d28 to
876292a
Compare
Why
PR #9847 computes maturity modulation locally but does not expose it via the canister API.
This adds a query endpoint so that external tools and dashboards can read the current
maturity modulation value, as defined by Mission 70.
https://dfinity.atlassian.net/browse/NNS1-4319
What
PR Chain