Skip to content

chore: add ic-xrc-types to workspace dependencies#9443

Merged
jasonz-dfinity merged 3 commits into
masterfrom
jason/add-ic-xrc-types-to-workspace
May 6, 2026
Merged

chore: add ic-xrc-types to workspace dependencies#9443
jasonz-dfinity merged 3 commits into
masterfrom
jason/add-ic-xrc-types-to-workspace

Conversation

@jasonz-dfinity
Copy link
Copy Markdown
Contributor

@jasonz-dfinity jasonz-dfinity commented Mar 17, 2026

Why

Several crates pin ic-xrc-types individually at various versions (1.0.0, 1.1.0). The Bazel side already pins ^1.2.0 in rust.MODULE.bazel. This consolidates the Cargo side to match.

What

  • Added ic-xrc-types = "1.2.0" to [workspace.dependencies] in the root Cargo.toml
  • Switched all 6 crates (including xrc_mock) from inline version pins to { workspace = true }

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR centralizes the ic-xrc-types dependency version by moving several crates from an inline pinned version to using the workspace-managed dependency, and adds ic-xrc-types to the workspace dependency list in the root Cargo.toml.

Changes:

  • Switched multiple rs/* crates from ic-xrc-types = "1.0.0" to ic-xrc-types = { workspace = true }.
  • Added ic-xrc-types = "1.0.0" under [workspace.dependencies] in the root Cargo.toml.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
rs/tests/testnets/Cargo.toml Uses workspace-managed ic-xrc-types instead of a crate-local pinned version.
rs/nns/test_utils/Cargo.toml Uses workspace-managed ic-xrc-types instead of a crate-local pinned version.
rs/nns/integration_tests/Cargo.toml Uses workspace-managed ic-xrc-types instead of a crate-local pinned version.
rs/nns/cmc/Cargo.toml Uses workspace-managed ic-xrc-types instead of a crate-local pinned version.
rs/nervous_system/integration_tests/Cargo.toml Uses workspace-managed ic-xrc-types instead of a crate-local pinned version.
Cargo.toml Adds ic-xrc-types to [workspace.dependencies] to support workspace-based dependency declarations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Cargo.toml Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR consolidates the ic-xrc-types crate versioning across the Rust workspace by moving it to the root [workspace.dependencies] and switching individual crates to inherit it, aligning Cargo’s dependency pin with the Bazel-side pin.

Changes:

  • Added ic-xrc-types = "1.2.0" to the root Cargo.toml under [workspace.dependencies].
  • Updated 6 crate Cargo.toml files to use ic-xrc-types = { workspace = true } instead of pinning versions locally.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Cargo.toml Adds ic-xrc-types as a workspace dependency at version 1.2.0.
rs/tests/testnets/Cargo.toml Switches ic-xrc-types to inherit from workspace dependencies.
rs/rust_canisters/xrc_mock/Cargo.toml Switches ic-xrc-types to inherit from workspace dependencies.
rs/nns/test_utils/Cargo.toml Switches ic-xrc-types to inherit from workspace dependencies.
rs/nns/integration_tests/Cargo.toml Switches ic-xrc-types to inherit from workspace dependencies.
rs/nns/cmc/Cargo.toml Switches ic-xrc-types to inherit from workspace dependencies.
rs/nervous_system/integration_tests/Cargo.toml Switches ic-xrc-types to inherit from workspace dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jasonz-dfinity jasonz-dfinity marked this pull request as ready for review April 14, 2026 21:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jasonz-dfinity jasonz-dfinity added this pull request to the merge queue May 6, 2026
Merged via the queue into master with commit fbdf88b May 6, 2026
43 checks passed
@jasonz-dfinity jasonz-dfinity deleted the jason/add-ic-xrc-types-to-workspace branch May 6, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants