fix(cmc): retry ICP burns that fail after cycles were already delivered - #11269
fix(cmc): retry ICP burns that fail after cycles were already delivered#11269Rachit2323 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
|
✅ No security or compliance issues detected. Reviewed everything up to 204431f. Security Overview
Detected Code Changes
|
The problem
When you send ICP to get cycles, CMC does two things: give you the cycles, then burn your ICP. If the burn fails, it just logs it and forgets. You keep the cycles, but your ICP never actually gets burned.
No retry, ever.
What I did
If the burn fails, save it instead of forgetting it. Try again every heartbeat until it works. Never repeat the "give you cycles" part again - only retry the burn.
Testing
Added tests for the new save/retry logic. All existing tests still pass.