chore: Remove attached LUKS header from Store partition#10604
Open
frankdavid wants to merge 5 commits into
Open
chore: Remove attached LUKS header from Store partition#10604frankdavid wants to merge 5 commits into
frankdavid wants to merge 5 commits into
Conversation
|
✅ No security or compliance issues detected. Reviewed everything up to eb8df54. Security Overview
Detected Code Changes
|
blind-oracle
approved these changes
Jun 30, 2026
| .await | ||
| .with_context(|| { | ||
| format!( | ||
| "Failed to write store LUKS header to {}", |
Contributor
There was a problem hiding this comment.
Maybe uppercase Store or quote it, otherwise looks like a typo
| false | ||
| }); | ||
|
|
||
| if self.store_luks_header_path.exists() && attached_header_present { |
Contributor
There was a problem hiding this comment.
Should we actively check that the existing header is valid? Or this is already done before somewhere?
| if self.store_luks_header_path.exists() { | ||
| bail!( | ||
| "Refusing to format Store because detached LUKS header {} already exists. \ | ||
| Remove the stale header first if you really want to reformat the device.", |
Contributor
There was a problem hiding this comment.
Hmm is this error even actionable? How can a user remove it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Store partition is now formatted with a detached LUKS header only. A legacy attached header still present on a device (which was the previous approach) is wiped on the next open, so only the detached header remains going forward.
In addition,
guest_disknow uses a shared metricsRegistryand writes all metrics once. The PR adds theguest_disk_store_attached_luks2_header_statusgauge to track the header migration state.