Skip to content

refactor: add RoutingTable::unassign_canister#10595

Merged
mraszyk merged 1 commit into
masterfrom
mraszyk/routing-table-unassign-canister
Jun 30, 2026
Merged

refactor: add RoutingTable::unassign_canister#10595
mraszyk merged 1 commit into
masterfrom
mraszyk/routing-table-unassign-canister

Conversation

@mraszyk

@mraszyk mraszyk commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

This PR adds a new public function RoutingTable::unassign_canister removing a canister from the routing table.

The motivation for adding this function is ability (in a follow-up PR) to implement canister migration to a deleted subnet by only removing the canister from the source subnet (using the new function RoutingTable::unassign_canister) without adding the canister to the deleted (target) subnet. This flow would be used if the target subnet is permanently stuck, preventing the canister migration from completing, and if the stuck subnet is then deleted.

@mraszyk mraszyk marked this pull request as ready for review June 29, 2026 10:15
@mraszyk mraszyk requested a review from a team as a code owner June 29, 2026 10:15

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@mraszyk mraszyk dismissed github-actions[bot]’s stale review June 29, 2026 10:16

No canister behavior changes.

@zeropath-ai

zeropath-ai Bot commented Jun 29, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 6784833.

Security Overview
Detected Code Changes
Change Type Relevant files
Refactor ► lib.rs
    Introduce unassign_canister and unassign_range functions
    Modify assign_canister to call unassign_canister
    Modify assign_range to call unassign_range

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new public API on RoutingTable to remove an individual canister assignment, enabling follow-up work where canister migration can be “undone” from the source subnet without reassigning to a (potentially deleted/stuck) target subnet.

Changes:

  • Refactors single-canister assignment to reuse a new unassign_canister step before inserting the singleton range.
  • Adds RoutingTable::unassign_canister (public) and factors out internal unassign_range logic to remove assignments for a canister ID range.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rs/registry/routing_table/src/lib.rs
@mraszyk mraszyk added this pull request to the merge queue Jun 30, 2026
Merged via the queue into master with commit b01c853 Jun 30, 2026
73 of 75 checks passed
@mraszyk mraszyk deleted the mraszyk/routing-table-unassign-canister branch June 30, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants