refactor: add RoutingTable::unassign_canister#10595
Conversation
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
No canister behavior changes.
|
✅ No security or compliance issues detected. Reviewed everything up to 6784833. Security Overview
Detected Code Changes
|
There was a problem hiding this comment.
Pull request overview
This PR introduces a new public API on RoutingTable to remove an individual canister assignment, enabling follow-up work where canister migration can be “undone” from the source subnet without reassigning to a (potentially deleted/stuck) target subnet.
Changes:
- Refactors single-canister assignment to reuse a new
unassign_canisterstep before inserting the singleton range. - Adds
RoutingTable::unassign_canister(public) and factors out internalunassign_rangelogic to remove assignments for a canister ID range.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR adds a new public function
RoutingTable::unassign_canisterremoving a canister from the routing table.The motivation for adding this function is ability (in a follow-up PR) to implement canister migration to a deleted subnet by only removing the canister from the source subnet (using the new function
RoutingTable::unassign_canister) without adding the canister to the deleted (target) subnet. This flow would be used if the target subnet is permanently stuck, preventing the canister migration from completing, and if the stuck subnet is then deleted.