chore: Extract Bazel Test Bare Metal job from schedule‑daily#10582
Open
frankdavid wants to merge 1 commit into
Open
chore: Extract Bazel Test Bare Metal job from schedule‑daily#10582frankdavid wants to merge 1 commit into
frankdavid wants to merge 1 commit into
Conversation
We can limit the secrets the workflow needs access to, so it's less risky if we ever want to run the workflow on non-submitted branches.
blind-oracle
approved these changes
Jul 2, 2026
basvandijk
approved these changes
Jul 7, 2026
Collaborator
There was a problem hiding this comment.
Note I added a dedicated Bare Metal Tests environment with the secrets:
ZH2_DLL01_CSV_SECRETSZH2_DLL01_INI_SECRETZH2_FILE_SHARE_KEY
That environment is available on the branches:
baremetal-*masterrc--*
Let's use that instead of the Nightly Tests environment.
Once this PR is merged I'll remove those secrets from the Nightly Tests environment.
| image: ghcr.io/dfinity/ic-build@sha256:0ed93dc568f53cce56042a86b31f98cd1bbb9cd3ea8e649532c366494b9c160a | ||
| options: >- | ||
| -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" | ||
| environment: Nightly Tests |
Collaborator
There was a problem hiding this comment.
Suggested change
| environment: Nightly Tests | |
| environment: Bare Metal Tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can limit the secrets the workflow needs access to, so it's less risky if we ever want to run the workflow on non-submitted branches.