fix: [DSM-103] Ignore executed_rounds when computing total AP#10092
Merged
alin-at-dfinity merged 1 commit intomasterfrom May 5, 2026
Merged
fix: [DSM-103] Ignore executed_rounds when computing total AP#10092alin-at-dfinity merged 1 commit intomasterfrom
alin-at-dfinity merged 1 commit intomasterfrom
Conversation
In tests checking that the total AP across the subnet is zero, ignore executed_rounds: the zero lower-bound invariant strictly applies to AP now.
schneiderstefan
approved these changes
May 5, 2026
Contributor
schneiderstefan
left a comment
schneiderstefan
left a comment
There was a problem hiding this comment.
Nit: Could you replace AP by "accumulated priority" at least at one place in either the title or the description, for clarity?
Contributor
Author
Good point, done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In tests checking that the accumulated priority (AP) sum across all canisters is zero, ignore
executed_rounds: the zero lower-bound invariant strictly applies to AP now.