refactor: [DSM-103] Debug-only SubnetSchedule::fully_executed_canisters field#10089
Merged
alin-at-dfinity merged 1 commit intomasterfrom May 5, 2026
Merged
Conversation
…rs field In debug mode, explicitly collect all fully executed canisters in a set within SubnetSchedule. This is because with active-canister-only scheduling, CanisterPriority entries for newly idle canisters may be dropped, making it impossible to test whether they had been fully executed or not. Strictly speaking, this is no longer necessary -- we used to drop CanisterPriority entries in RoundSchedule::finish_round(), now we only drop them in the next RoundSchedule::start_iteration(), i.e. in the next round -- but the implementation may change and it's nice to have a safety net.
schneiderstefan
approved these changes
May 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
alin-at-dfinity
deleted the
alin/DSM-103-SubnetSchedule-fully_executed_canisters
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In debug mode, explicitly collect all fully executed canisters in a set within
SubnetSchedule. This is because with active-canister-only scheduling,CanisterPriorityentries for newly idle canisters may be dropped, making it impossible to test whether they had been fully executed or not.Strictly speaking, this is no longer necessary -- we used to drop
CanisterPriorityentries inRoundSchedule::finish_round(), now we only drop them in the subsequentRoundSchedule::start_iteration(), i.e. in the next round -- but the implementation may change and it's nice to have a safety net.