Skip to content

feat: Add canister_metrics management canister endpoint#10088

Merged
michael-weigelt merged 1 commit intodfinity:masterfrom
dsarlis:dimitris/management-canister-metrics
May 5, 2026
Merged

feat: Add canister_metrics management canister endpoint#10088
michael-weigelt merged 1 commit intodfinity:masterfrom
dsarlis:dimitris/management-canister-metrics

Conversation

@dsarlis
Copy link
Copy Markdown
Contributor

@dsarlis dsarlis commented May 5, 2026

Implement the canister_metrics endpoint as described in dfinity/portal#6217 to allow controllers or subnet admins to retrieve canister level metrics for a target canister. The metrics currently contain some basic cycles related ones but can be extended in the future to contain more.

The necessary boilerplate is added to wire the new endpoint through the code stack. As defined in the interface spec, the API is available both in replicated mode as well as a query call.

A few tests are also added to ensure that the endpoint correctly returns the values that are present in the replicated state.

@dsarlis dsarlis requested review from a team as code owners May 5, 2026 09:21
@github-actions github-actions Bot added the feat label May 5, 2026
@basvandijk basvandijk added the security-review-passed IDX or InfraSec have concluded it's safe to run CI on the external PR. label May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Comment thread rs/execution_environment/src/canister_manager/tests.rs
@dsarlis dsarlis requested a review from michael-weigelt May 5, 2026 10:13
@michael-weigelt michael-weigelt enabled auto-merge May 5, 2026 12:00
@michael-weigelt michael-weigelt added this pull request to the merge queue May 5, 2026
Merged via the queue into dfinity:master with commit 092ab71 May 5, 2026
15 of 16 checks passed
@michael-weigelt michael-weigelt deleted the dimitris/management-canister-metrics branch May 5, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor feat security-review-passed IDX or InfraSec have concluded it's safe to run CI on the external PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants