Skip to content

fix: instructions for Operator::ReturnCallIndirect#10086

Merged
mraszyk merged 2 commits into
masterfrom
mraszyk/return-call-indirect-instructions
May 5, 2026
Merged

fix: instructions for Operator::ReturnCallIndirect#10086
mraszyk merged 2 commits into
masterfrom
mraszyk/return-call-indirect-instructions

Conversation

@mraszyk
Copy link
Copy Markdown
Contributor

@mraszyk mraszyk commented May 5, 2026

This PR fixes the instruction count for Operator::ReturnCallIndirect to be 2x that of Operator::ReturnCall consistently with Operator::CallIndirect being 2x that of Operator::Call.

@github-actions github-actions Bot added the fix label May 5, 2026
@mraszyk mraszyk added the CI_ALL_BAZEL_TARGETS Runs all bazel targets label May 5, 2026
@mraszyk mraszyk marked this pull request as ready for review May 5, 2026 09:23
@mraszyk mraszyk requested a review from a team as a code owner May 5, 2026 09:23
@mraszyk mraszyk added this pull request to the merge queue May 5, 2026
Merged via the queue into master with commit c0d49f2 May 5, 2026
40 checks passed
@mraszyk mraszyk deleted the mraszyk/return-call-indirect-instructions branch May 5, 2026 10:08
@ggreif
Copy link
Copy Markdown
Contributor

ggreif commented May 5, 2026

@mraszyk @schneiderstefan just for the record, I got the word from Alex Uta that the early version of wasmtime this was originally benchmarked on actually arrived at the crazy cost of 60. It might have well went down in the meantime. Were those benches automatised for an easy re-run?

@schneiderstefan
Copy link
Copy Markdown
Contributor

@mraszyk @schneiderstefan just for the record, I got the word from Alex Uta that the early version of wasmtime this was originally benchmarked on actually arrived at the crazy cost of 60. It might have well went down in the meantime. Were those benches automatised for an easy re-run?

@ggreif Thanks for pointing that out. I wasn't aware. I suggest we just revert the PR, as the previous number seems to have had a better claim at being data driven.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants