chore: forward-looking AGENTS.md, pinned ICP skills, contribution policy, dfx-era cleanup - #1465
Open
marc0olo wants to merge 1 commit into
Open
chore: forward-looking AGENTS.md, pinned ICP skills, contribution policy, dfx-era cleanup#1465marc0olo wants to merge 1 commit into
marc0olo wants to merge 1 commit into
Conversation
…icy, dfx-era cleanup The dfx→icp-cli migration is complete, so the repo's meta files are rewritten around what matters going forward: - AGENTS.md: trimmed 551→~230 lines. Migration checklist and all version pins removed (versions come from the most recently updated examples); CI section rewritten around the reusable _run-example.yml; new conventions documented: environments are exactly 'local' and 'ic' (the 'ic' name is the ICP Ninja deploy contract), canister:import + --actor-env-alias for inter-canister calls, version-bump scope rule, and the new-example acceptance criteria (from ADDING_AN_EXAMPLE.md). - ICP skills: pinned setup per dfinity/icskills#251 — managed block in AGENTS.md (pinned, ask-to-update), committed skills-lock.json, .agents/skills gitignored (reinstall with npx skills). - Contribution policy: CONTRIBUTING.md rewritten — not accepting external PRs while examples are being restructured to fit the developer docs; issues and forum posts remain welcome. ADDING_AN_EXAMPLE.md deleted (criteria folded into AGENTS.md). - Dead machinery deleted: .ic-commit + its weekly update workflow and the orphaned provision/cache scripts (CI runs in icp-dev-env containers), plus .gitmodules (referenced a long-gone archive/ submodule). - .gitignore hygiene: root file regrouped with comments; dead .dfx/ and _MACOSX entries dropped; stale dfx-era entries removed from three per-example .gitignore files. Lock-file entries unchanged per #1457. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mraszyk
approved these changes
Jul 30, 2026
mraszyk
left a comment
mraszyk
left a comment
Contributor
There was a problem hiding this comment.
approving the simple change in rust/low_wasm_memory/.gitignore
mbjorkqvist
approved these changes
Jul 30, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates repository meta-docs and housekeeping files to reflect the completed dfx → icp-cli migration, codifies forward-looking conventions for examples, and removes legacy CI/provisioning machinery that’s no longer used.
Changes:
- Rewrites
AGENTS.mdto document current conventions (icp-cli-first, version placeholders,local/icenvironments, inter-canister aliasing, canonical layouts). - Pins ICP agent skills via
skills-lock.jsonand ignores local skill installations under.agents/skills. - Cleans up dfx-era artifacts and ignores (removes
.ic-commit, submodule metadata, old provision/update scripts; trims per-example.gitignoreentries).
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
skills-lock.json |
Adds a pinned skills lockfile for reproducible agent skill resolution. |
AGENTS.md |
Replaces migration-era guidance with forward-looking repo conventions and updated templates. |
.github/CONTRIBUTING.md |
Updates contribution policy to pause external PR acceptance and directs users to issues/forum for reports. |
.gitignore |
Reorganizes ignore patterns; adds .agents/skills ignore; keeps existing lockfile ignore policy. |
rust/low_wasm_memory/.gitignore |
Removes dfx-specific ignore entries that are no longer relevant. |
rust/basic_bitcoin/.gitignore |
Removes dfx-era ignores and stale canister_ids.json ignore entry. |
motoko/ic-pos/.gitignore |
Removes dfx-era ignores and stale canister_ids.json ignore entry. |
ADDING_AN_EXAMPLE.md |
Removes redundant “add an example” doc now folded into AGENTS.md. |
.ic-commit |
Removes legacy IC artifact pin used by old provisioning/update flows. |
.gitmodules |
Removes unused submodule metadata referencing deleted archive/ content. |
.github/workflows/update-ic-commit.yml |
Removes legacy scheduled workflow for updating IC artifacts. |
.github/workflows/update-dfx-cache.sh |
Removes dfx-cache update script no longer used by CI. |
.github/workflows/provision-pocket-ic-server.sh |
Removes legacy PocketIC provisioning script superseded by containerized CI. |
.github/workflows/provision-linux.sh |
Removes legacy Linux provisioning script (toolchain now comes from CI container images). |
.github/workflows/provision-darwin.sh |
Removes legacy macOS provisioning script (CI is containerized/Linux). |
.github/workflows/pre-download-launcher.sh |
Removes launcher predownload workaround script that’s no longer referenced. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dfx→icp-cli migration is complete. This PR rewrites the repo's meta files around what matters going forward.
AGENTS.md (551 → ~230 lines)
vX.Y.Zplaceholders; a Versions section says to take current versions from the most recently updated examples (the doc was already wrong — it showed@dfinity/asset-canisterwhile all 40 frontends use@dfinity/static-site)._run-example.ymlreality.localandic(theicname is the ICP Ninja deploy contract; never a defaultstaging),canister:imports +--actor-env-aliasfor inter-canister calls, version-bump scope rule (ask repo-wide vs. single example — applies to recipes too), new-example acceptance criteria, docs-over-product link rule.ICP skills (dfinity/icskills#251 ceremony)
<!-- ic-skills:managed -->block in pinned, ask-to-update mode (copied verbatim from the ceremony).skills-lock.jsoncommitted;.agents/skillsgitignored — reinstall withnpx skills experimental_install.Contribution policy
ADDING_AN_EXAMPLE.mddeleted; its acceptance criteria (educational focus, docs home, DX-team maintenance, both languages) folded into AGENTS.md.Dead machinery removed
.ic-commit+update-ic-commit.yml(weekly bot PRs updating dfx-cache artifacts — last used 2024-08) and the five orphaned provision/cache scripts; CI runs in icp-dev-env containers..gitmodules— referenced a submodule under the long-deletedarchive/tree..gitignore hygiene
Root file regrouped with comments; dead
.dfx/and_MACOSXentries dropped; stale dfx-era entries removed frommotoko/ic-pos,rust/basic_bitcoin,rust/low_wasm_memory.Cargo.lock/mops.lockentries deliberately untouched — parked in #1457.🤖 Generated with Claude Code