docs: add protocol stack concept pages (Batch 1)#209
Open
marc0olo wants to merge 5 commits intoinfra/learn-hub-migration-prepfrom
Open
docs: add protocol stack concept pages (Batch 1)#209marc0olo wants to merge 5 commits intoinfra/learn-hub-migration-prepfrom
marc0olo wants to merge 5 commits intoinfra/learn-hub-migration-prepfrom
Conversation
…ng, execution, state sync) Migrates 6 Learn Hub articles from the "Blockchain Protocol" section into docs/concepts/protocol/: index, consensus, peer-to-peer, message-routing, execution, and state-synchronization. Updates cross-links in network-overview.md and glossary.md to point to the new internal pages instead of learn.internetcomputer.org.
Member
Author
|
Review notes The structure, content, and internal links all look good. One issue needs to be fixed before merge: Em-dashes (banned per CLAUDE.md): All 6 new files use em-dashes ( No other issues: frontmatter complete on all pages, all internal links resolve, |
This was referenced May 6, 2026
Member
Author
Review feedback1. Em-dashes (16 instances across 6 files)Em-dashes are banned project-wide per CLAUDE.md. Replace all
2. Terminology mismatch in
|
All em-dashes in Further reading bullets and numbered list items replaced with colons per project style rules. "The blockchain state" corrected to "The subnet state" in state-synchronization.md for terminology consistency.
Member
Author
|
Feedback addressed:
|
marc0olo
added a commit
that referenced
this pull request
May 6, 2026
…ers pages - Fix AccountIdentifier em-dash in token-ledgers.md - Revert chain-fusion/ subdirectory links to chain-fusion.md (flat page on main) until PR #213 merges; affects token-ledgers.md and concepts/index.md - Remove broken link to protocol/execution.md#deterministic-time-slicing in cycles.md until PR #209 merges
…minology - protocol/index.md: drop "utility token" framing and blockchain analogy sentence - consensus.md: remove Bitcoin-like protocols comparison; reframe probabilistic finality - execution.md: remove "reverse gas model" from description and body; reframe canister-pays model; drop "traditional blockchains" comparison; replace "decentralized autonomous organization" with "community-governed application"
Member
Author
|
Brand voice audit applied. The following fixes were committed in eb66cd9: Fixed automatically:
Open items for human review (no code change made):
|
…urrence New glossary entries: block maker, Deterministic Time Slicing (DTS), orthogonal persistence, random beacon, Trusted Execution Environment (TEE), XNet Per-page link fixes: - consensus.md: link block maker and random beacon to new glossary entries - peer-to-peer.md: link NNS to glossary on first use - message-routing.md: link ingress messages, XNet, induction pool, NNS, catch-up package to glossary - execution.md: link cycles and query to glossary; link orthogonal persistence to its concept page - state-synchronization.md: link catch-up package to glossary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/concepts/protocol/subdirectory with 6 new concept pages: protocol stack overview, consensus, peer-to-peer, message routing, execution, and state synchronizationdocs/concepts/network-overview.md: replaces Learn Hub link withconcepts/protocol/index.mddocs/references/glossary.md: replaces 5 Learn Hub links for consensus, peer-to-peer, and message routing entriesStaging files deleted
.migration/learn-hub/how-does-icp-work/blockchain-protocol/blockchain-protocol.md→docs/concepts/protocol/index.md.migration/learn-hub/how-does-icp-work/blockchain-protocol/consensus.md→docs/concepts/protocol/consensus.md.migration/learn-hub/how-does-icp-work/blockchain-protocol/peer-to-peer.md→docs/concepts/protocol/peer-to-peer.md.migration/learn-hub/how-does-icp-work/blockchain-protocol/message-routing.md→docs/concepts/protocol/message-routing.md.migration/learn-hub/how-does-icp-work/blockchain-protocol/execution-layer.md→docs/concepts/protocol/execution.md.migration/learn-hub/how-does-icp-work/blockchain-protocol/state-synchronization.md→docs/concepts/protocol/state-synchronization.mdSync recommendation
hand-written