Add float type to the raw method. Added a test for the raw method#12
Closed
yurikuzn wants to merge 6 commits intodevtheorem:masterfrom
Closed
Add float type to the raw method. Added a test for the raw method#12yurikuzn wants to merge 6 commits intodevtheorem:masterfrom
raw method. Added a test for the raw method#12yurikuzn wants to merge 6 commits intodevtheorem:masterfrom
Conversation
This is an internal class which shouldn't be part of the public API.
The `helpers` compilation option has been removed, and all helpers must now be passed at runtime when executing the template (just like in Handlebars.js). This can significantly reduce compile time, since PHP files no longer have to be read and tokenized to extract helper functions. It also enables sharing helper closures across multiple templates, and removes limitations on what they can access and do. Additionally, implemented `knownHelpers` option and updated `knownHelpersOnly` to work the same as in Handlebars.js. This now makes it possible to disable individual built-in helpers. Also unified partial closures and improved param types. Compiled templates and partials now have the same function signature to avoid duplicated logic. Memory usage when running tests decreased from 20 MB to 18 MB.
This can double runtime performance for complex templates with conditions in nested loops.
Collaborator
|
Thank you for filing the issue and working on a fix. I ended up resolving and testing the issue in a slightly different way (see 6069dc4), but I appreciate the effort you put into this and I hope you will contribute again in the future! The fix will be released soon as part of v1.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11.