Support sync invoke #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoalaBryson
force-pushed
the
support_sync_invoke
branch
from
ff7b861 to
0446598
Compare
Change-Id: I0c2c3b6fafbfc43eae67abee2811cfa0069476c3
KoalaBryson
force-pushed
the
support_sync_invoke
branch
from
6330feb to
c106572
Compare
CiCi503
reviewed
Jan 19, 2026
| else: | ||
| # 失败：result 是 (status_code, error_type, error_message) | ||
| status_code, error_type, error_message = result | ||
| return jsonify({ |
Collaborator
There was a problem hiding this comment.
错误处理应该放到哪里？现在到处都是 return json 。
task_manager 作为一个内部方法应该不能直接返回错误给客户端。层次要分明，返回结果需要在 handler 里构造
推荐方案：
方案A：使用自定义异常类（推荐）
KoalaBryson
force-pushed
the
support_sync_invoke
branch
from
91f5bce to
989aeed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.