Support authentication configuration and updates to case-sensitive API calls.#225
Open
sob wants to merge 2 commits intodevopsarr:mainfrom
Open
Support authentication configuration and updates to case-sensitive API calls.#225sob wants to merge 2 commits intodevopsarr:mainfrom
sob wants to merge 2 commits intodevopsarr:mainfrom
Conversation
Collaborator
|
Hi @sob, |
Fuochi
requested changes
Feb 9, 2025
Collaborator
Fuochi
left a comment
Fuochi
left a comment
There was a problem hiding this comment.
Generally speaking. I'd keep the second commit as it is, while I would like to be consistent with the other providers.
If you don't mind, you can change only the api case, and leave the pointer up to me.
Also, please use conventional commit.
Comment on lines
+126
to
+132
| pointerResponse := make([]*readarr.CustomFormatResource, len(response)) | ||
| for i := range response { | ||
| pointerResponse[i] = &response[i] | ||
| } | ||
|
|
||
| formats := make([]CustomFormat, len(pointerResponse)) | ||
| for i, p := range pointerResponse { |
Collaborator
There was a problem hiding this comment.
I'd like to align this provider's code with the other ones instead of doing this. Do you mind changing only the API case in this commit? I'll then add few commits to align with the other providers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.