Skip to content

#2255: Extract MSI build logic into shell script - #2262

Open
Caylipp wants to merge 1 commit into
devonfw:mainfrom
Caylipp:feature/2255-extract-msi-build-script
Open

#2255: Extract MSI build logic into shell script#2262
Caylipp wants to merge 1 commit into
devonfw:mainfrom
Caylipp:feature/2255-extract-msi-build-script

Conversation

@Caylipp

@Caylipp Caylipp commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

This PR fixes #2255

No macOS PKG build exists in the current workflows, so this PR only extracts the Windows MSI build.

Implemented changes:

  • Add windows-installer/build-msi.sh
  • Replace the inline MSI build logic in nightly-build.yml
  • Replace the inline MSI build logic in release.yml
  • Keep the workflows focused on orchestration

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. Validated the shell script syntax with:
    bash -n windows-installer/build-msi.sh

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Aug 4, 2026
@Caylipp Caylipp self-assigned this Aug 4, 2026
@Caylipp Caylipp added enhancement New feature or request bash bash, zsh, git-bash (integration, scripts) internal Nothing to be added to CHANGELOG, only internal story workflow GitHub actions (CI,CD,update urls/CVEs) labels Aug 4, 2026
@Caylipp Caylipp moved this from 🆕 New to Team Review in IDEasy board Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bash bash, zsh, git-bash (integration, scripts) enhancement New feature or request internal Nothing to be added to CHANGELOG, only internal story workflow GitHub actions (CI,CD,update urls/CVEs)

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

Refactor build logic from GitHub Workflows into dedicated shell scripts

1 participant