#2183: dynamically generate form fields for selected commandlet by Hiepiscus · Pull Request #2233 · devonfw/IDEasy

Hiepiscus · 2026-07-29T13:28:46Z

This PR fixes #2183

Introduces dynamic form generation for commandlets. Instead of using a static input field, the UI now creates appropriate form fields based on the properties of the selected commandlet for a more flexible configuration experience.
Show more lines

Implemented changes:

Dynamically generate form fields based on the selected commandlet properties
PropertyFormFieldFactory (new): create appropriate UI based on commandlet:
- TextField for positional parameters and named options
- CheckBox for boolean flags
Replaced static TextField with a ScrollPane + VBox in the FXML layout
Added onCommandletSelected() listener to regenerate the form on selection change
Adapted runCommandlet() to read property values from generated form fields

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

Run AppLauncher
Set a project and workspace
Click Commandlets
Select a commandlet from the combobox
Verify that the displayed form fields change depending on the selected commandlet
Enter parameters in the generated fields
Click Run
Verify that the commandlet executes successfully

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

When running mvn clean test locally all tests pass and build is successful
PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
PR top-level comment summarizes what has been done and contains link to addressed issue(s)
PR and issue(s) have suitable labels
Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
You followed all coding conventions
You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
with internal
You have formulated clear instructions on how to test your contribution under "Testing instructions"

…ts in a combobox

…andlet view

…ts in a combobox

…andlet view

…let-view' into 2182-basic-structure-for-commandlet-view

… selected commandlet

…ateFormFields

quando632

Nice split into PropertyFormFieldFactory, that keeps the controller readable. Checking KeywordProperty before BooleanProperty is easy to get wrong since one extends the other, and it is correct here. All three tasks from #2183 are covered.

One theme runs through the findings: runCommandlet executes a different order than AbstractIdeContext.applyAndRun (reset, assign, validate, run), while working on the commandlet singletons that CommandletManagerImpl shares with the CLI context.

Still open from the DoD checklist: the CHANGELOG.adoc entry, and tests. The gui module already has AppBaseTest and HeadlessApplicationTest, and PropertyFormFieldFactory is a static factory, so "property type maps to expected node type" should be cheap to assert.

quando632 · 2026-08-03T12:57:57Z

+          property) {
+        for (javafx.scene.Node child : hbox.getChildren()) {
+          if (child instanceof javafx.scene.control.TextField textField) {
+            property.setValueAsString(textField.getText(), context);


Blank fields are assigned as well, and ToolProperty.parse("") throws, so pressing Run on install without input ends in the default uncaught exception handler. Skipping blank input leaves the property unset, which is what the CLI does for a missing optional argument.

Suggested change

property.setValueAsString(textField.getText(), context);

String value = textField.getText();

if (!value.isBlank()) {

property.assignValueAsString(value, this.context, this.selectedCommandlet);

}

quando632 · 2026-08-03T12:57:57Z

+      }
+    }
+
+    this.selectedCommandlet.run();


Without validate() a missing required value reaches run(), for example create would start with an empty project name. validate() gives us the message to show instead. Needs imports of com.devonfw.tools.ide.validation.ValidationResult and com.devonfw.ide.gui.modal.IdeDialog.

Suggested change

this.selectedCommandlet.run();

ValidationResult result = this.selectedCommandlet.validate();

if (!result.isValid()) {

new IdeDialog(IdeDialog.AlertType.ERROR, result.getErrorMessage()).showAndWait();

return;

}

this.selectedCommandlet.run();

quando632 · 2026-08-03T12:57:57Z

+    }
+
+    this.selectedCommandlet.run();
+  }


applyAndRun also calls ensureLicenseAgreement(cmd) and checks isIdeHomeRequired() and isIdeRootRequired() before running. Skipping the license gate means a tool can be installed from the GUI without the agreement the CLI asks for.

Addressed. I added the validate() check before running the commandlet, but moved the validation logic into a dedicated method.

quando632 · 2026-08-03T12:57:58Z

+      Parent root = loader.load();
+
+      Stage stage = (Stage) selectedProject.getScene().getWindow();
+      stage.setScene(new Scene(root));


Replacing the scene of the primary stage leaves no way back to the main view, so the app has to be restarted after opening the commandlet view. A back button in commandlet-view.fxml or a separate Stage for the view would solve it.

Thanks for the suggestion. I've updated the navigation logic so that the commandlet view is displayed in the existing window by replacing the center content of the BorderPane. A back button was added to the commandlet view, allowing users to return to the main view without restarting the application.

quando632 · 2026-08-03T12:57:58Z

+      }
+    }
+
+    this.selectedCommandlet.run();


The result of the run never reaches the view. A success writes everything to the console and leaves the window unchanged, and a failure escapes as an uncaught exception, for example build outside a project throws CliException: Could not find build descriptor straight out of the handler. Wrapping run() in a try/catch and reporting both outcomes in the view would close the loop.

quando632 · 2026-08-03T12:57:58Z

+    commandletSelector.getItems().clear();
+    commandletSelector.getItems().addAll(context.getCommandletManager().getCommandlets().stream()
+        .map(Commandlet::getName)
+        .toList());


nit: .sorted() was dropped in 8f8f191, so the combo box lists about 40 commandlets unsorted. Was that intentional?

The removal was intentional. I was considering a future approach where frequently used commandlets would be shown first. However, the current unsorted order is not predictable, so I've added .sorted() back for now.

quando632 · 2026-08-03T12:57:58Z

+      return name;
+    }
+
+    if (name.isEmpty() && alias != null) {


nit: the non option branch reimplements Property#getNameOrAlias().

Co-authored-by: quando632 <quang-hieu.do@capgemini.com>

pane with back button

Hiepiscus added 15 commits July 21, 2026 10:02

devonfw#2129: add AutoCompletionRegistry.add(candidate, synonym)

b03f892

devonfw#2129: move and group maven completions to MavenCommandlet

9e944d8

devonfw#2129: remove comments

42568ae

devonfw#2129: remove mvnd specific properties from MavenCommandlet

1fc8922

devonfw#2182: add commandlet view and navigation button

28d8995

devonfw#2182: add new CommandletController that display all commandle…

b71f72c

…ts in a combobox

devonfw#2182: add openCommandlet() to MainController to open the comm…

6c75ba6

…andlet view

devonfw#2182: add commandlet view and navigation button

f0f38c6

devonfw#2182: add new CommandletController that display all commandle…

23e8e80

…ts in a combobox

devonfw#2182: add openCommandlet() to MainController to open the comm…

db9a466

…andlet view

Merge remote-tracking branch 'origin/2182-basic-structure-for-command…

40aaa2b

…let-view' into 2182-basic-structure-for-commandlet-view

devonfw#2182: implement runCommandlet to parse parameters and execute…

a1f6cd4

… selected commandlet

devonfw#2182: remove sorted list and correct a few formatting violations

8f8f191

devonfw#2183: generate form fields for selected commandlet

d394d95

devonfw#2183: change from ToggleButton to Checkbox and refactor gener…

0fd442a

…ateFormFields

github-project-automation Bot added this to IDEasy board Jul 29, 2026

github-project-automation Bot moved this to 🆕 New in IDEasy board Jul 29, 2026

Hiepiscus self-assigned this Jul 29, 2026

Hiepiscus added GUI Graphical User Interface of IDEasy (aka dashboard) build with JavaFx commandlet ide sub-command labels Jul 29, 2026

Hiepiscus moved this from 🆕 New to Team Review in IDEasy board Jul 29, 2026

hohwille assigned quando632 Aug 3, 2026

quando632 suggested changes Aug 3, 2026

View reviewed changes

Hiepiscus and others added 7 commits August 3, 2026 16:46

Update gui/src/main/java/com/devonfw/ide/gui/MainController.java

176c8ec

Co-authored-by: quando632 <quang-hieu.do@capgemini.com>

Update gui/src/main/resources/com/devonfw/ide/gui/main-view.fxml

edcb6eb

Co-authored-by: quando632 <quang-hieu.do@capgemini.com>

Update gui/src/main/java/com/devonfw/ide/gui/CommandletController.java

8f28f59

Co-authored-by: quando632 <quang-hieu.do@capgemini.com>

Update gui/src/main/java/com/devonfw/ide/gui/CommandletController.java

68958f7

Co-authored-by: quando632 <quang-hieu.do@capgemini.com>

devonfw#2183: integrate commandlet view into center

fbafdff

pane with back button

devonfw#2183: apply review changes

65e67ce

devonfw#2183: add tests for PropertyFormFieldFactory

931da70

Hiepiscus added 3 commits August 4, 2026 14:59

devonfw#2183: edit CHANGELOG.adoc

aced5f0

devonfw#2183: edit CHANGELOG.adoc

bbc4974

devonfw#2183: add sorted() back

3f53c75

Navigation Menu

Uh oh!

#2183: dynamically generate form fields for selected commandlet - #2233

#2183: dynamically generate form fields for selected commandlet#2233
Hiepiscus wants to merge 25 commits into
devonfw:mainfrom
Hiepiscus:2183-dynamically-generate-form-fields-for-selected-commandlet

Hiepiscus commented Jul 29, 2026 •

edited

Loading

Uh oh!

quando632 left a comment

Uh oh!

Uh oh!

Uh oh!

quando632 Aug 3, 2026

Uh oh!

quando632 Aug 3, 2026

Uh oh!

quando632 Aug 3, 2026

Uh oh!

Hiepiscus Aug 4, 2026

Uh oh!

quando632 Aug 3, 2026

Uh oh!

Hiepiscus Aug 4, 2026

Uh oh!

Uh oh!

quando632 Aug 3, 2026

Uh oh!

quando632 Aug 3, 2026

Uh oh!

Hiepiscus Aug 4, 2026

Uh oh!

quando632 Aug 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-            property.setValueAsString(textField.getText(), context);
+            String value = textField.getText();
+            if (!value.isBlank()) {
+              property.assignValueAsString(value, this.context, this.selectedCommandlet);
+            }

-    this.selectedCommandlet.run();
+    ValidationResult result = this.selectedCommandlet.validate();
+    if (!result.isValid()) {
+      new IdeDialog(IdeDialog.AlertType.ERROR, result.getErrorMessage()).showAndWait();
+      return;
+    }
+    this.selectedCommandlet.run();

Uh oh!

Conversation

Hiepiscus commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This PR fixes #2183

Implemented changes:

Testing instructions

Checklist for this PR

Uh oh!

quando632 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Hiepiscus commented Jul 29, 2026 •

edited

Loading