Skip to content

Enhance PR template with testing instructions#1931

Open
laim2003 wants to merge 3 commits into
devonfw:mainfrom
laim2003:patch-1
Open

Enhance PR template with testing instructions#1931
laim2003 wants to merge 3 commits into
devonfw:mainfrom
laim2003:patch-1

Conversation

@laim2003
Copy link
Copy Markdown
Contributor

This PR fixes

Implemented changes:

  • Added section for testing instructions in PR template.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

Added section for testing instructions in PR template.
@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board May 12, 2026
@laim2003 laim2003 marked this pull request as ready for review May 12, 2026 12:06
@laim2003 laim2003 moved this from 🆕 New to Team Review in IDEasy board May 12, 2026
@laim2003 laim2003 added the internal Nothing to be added to CHANGELOG, only internal story label May 12, 2026
@areinicke areinicke self-assigned this May 12, 2026
@laim2003 laim2003 assigned laim2003 and areinicke and unassigned areinicke May 12, 2026
@laim2003 laim2003 requested review from areinicke and hohwille May 12, 2026 12:10
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 12, 2026

Coverage Report for CI Build 25734571853

Coverage increased (+0.05%) to 70.673%

Details

  • Coverage increased (+0.05%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15471
Covered Lines: 11393
Line Coverage: 73.64%
Relevant Branches: 6918
Covered Branches: 4430
Branch Coverage: 64.04%
Branches in Coverage %: Yes
Coverage Strength: 3.11 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@areinicke areinicke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. This will probably be quite valuable for future PRs.
I would have probably added the Testing Instructions above the checklist or below the Tool Commandlet checklist but it's fine either way.

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
@laim2003
Copy link
Copy Markdown
Contributor Author

Looks fine to me. This will probably be quite valuable for future PRs. I would have probably added the Testing Instructions above the checklist or below the Tool Commandlet checklist but it's fine either way.

Yeah, good idea. I thought it might make sense to put it in the middle so you dont have to scroll down all the way in case you do not have a PR that requires the commandlet checklist, but honestly the order makes more sense if the testing checklist is in the end

@laim2003 laim2003 moved this from Team Review to 👀 In review in IDEasy board May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Nothing to be added to CHANGELOG, only internal story

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

3 participants