chore: adopt ds-spring-user-framework 5.1.1#78
Merged
Conversation
Picks up the RequestCache hardening + auto-unprotect of browser icon probes (fixes the post-login redirect hijack to /apple-touch-icon.png?continue). Once 5.1.1 is adopted, the framework auto-unprotects /apple-touch-icon*.png, so the demo's manual /apple-touch-icon* whitelist entry (#77) becomes redundant-but-harmless. BLOCKED: do not merge until 5.1.1 is published to Maven Central.
devondragon
marked this pull request as ready for review
July 24, 2026 17:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft — blocked on the 5.1.1 release. Do not merge until
ds-spring-user-framework:5.1.1is published to Maven Central.Bumps
ds-spring-user-framework5.1.0→5.1.1:RequestCache(won't save browser auto-probe requests, so an icon probe can't hijack the post-login redirect)/apple-touch-icon*.png,/favicon.*,/.well-known/**Framework PR: devondragon/SpringUserFramework#343 (merged, awaiting release).
Note on overlap with #77: once 5.1.1 is adopted, the framework auto-unprotects
/apple-touch-icon*.png, so the manual/apple-touch-icon*whitelist entry added in #77 becomes redundant-but-harmless. Either merge #77 first (keeps the explicit demo config) or drop it in favor of the framework default — your call.Merge checklist