fix(webjs): handle null chat in typing and seen endpoints#1979
Open
saschabuehrle wants to merge 1 commit intodevlikeapro:corefrom
Open
fix(webjs): handle null chat in typing and seen endpoints#1979saschabuehrle wants to merge 1 commit intodevlikeapro:corefrom
saschabuehrle wants to merge 1 commit intodevlikeapro:corefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
#1970 —
POST /api/startTypingreturns a 500 Internal Server Error withTypeError: Cannot read properties of undefined (reading 'sendStateTyping')when the target number does not have WhatsApp.Fix
Added null checks after
getChatById()in the WEBJS engine'sstartTyping,stopTyping, andsendSeenmethods. When the chat object is not found (e.g. the number has no WhatsApp account), these endpoints now throw aNotFoundExceptionwith a descriptive message instead of crashing with an unhandledTypeError.The same pattern is already used elsewhere in the codebase (e.g. session manager's
NotFoundException).Testing
Verified that the fix correctly guards all three affected methods. NestJS maps
NotFoundExceptionto a 404 HTTP response, giving callers a clear signal that the chat does not exist rather than an opaque 500 error.Happy to address any feedback.
Greetings, saschabuehrle