feat: add check_name input for per-run GitHub check names - #7
Merged
Conversation
A commit tested more than once posts GitHub checks that all share one name, and
GitHub matches required checks by name — so branch protection holds a single
entry for all of them and the gate follows whichever run finished last.
check_name rides through as a gh_check_name metadata pair, which the backend
appends to the base name ("DeviceCloud / iOS").
Passed as its own quoted `-m` pair rather than folded into metadata_parsed:
that variable is expanded unquoted, so a check name containing a space would
split into two argv entries and the stray word would land where the positional
app file / workspace go.
The npx stub now echoes one line per argv entry so the test can tell those two
cases apart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A commit tested more than once posts GitHub checks that all share one name, and GitHub matches required checks by name — so branch protection holds a single entry for all of them and the gate follows whichever run finished last. check_name rides through as a gh_check_name metadata pair, which the backend appends to the base name ("DeviceCloud / iOS").
Passed as its own quoted
-mpair rather than folded into metadata_parsed: that variable is expanded unquoted, so a check name containing a space would split into two argv entries and the stray word would land where the positional app file / workspace go.The npx stub now echoes one line per argv entry so the test can tell those two cases apart.