Skip to content

fix: prevent segmentation fault in CIRA tunnel session timer (#776)#788

Open
amarnath-ac wants to merge 1 commit intomainfrom
fix_segfault
Open

fix: prevent segmentation fault in CIRA tunnel session timer (#776)#788
amarnath-ac wants to merge 1 commit intomainfrom
fix_segfault

Conversation

@amarnath-ac
Copy link

@amarnath-ac amarnath-ac commented Feb 10, 2026

  1. Initialize APF session timer to prevent nil pointer dereference
    during CIRA connection cleanup.
  2. Replace direct CIM.Chip.Get() calls with Enumerate+Pull pattern to handle
    empty/malformed chip data gracefully and prevent connection termination.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

❌ Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.75%. Comparing base (5b7221f) to head (75cf416).

Files with missing lines Patch % Lines
internal/controller/tcp/cira/tunnel.go 44.44% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
+ Coverage   39.63%   39.75%   +0.12%     
==========================================
  Files         113      113              
  Lines       10754    10761       +7     
==========================================
+ Hits         4262     4278      +16     
+ Misses       6093     6084       -9     
  Partials      399      399              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@amarnath-ac amarnath-ac force-pushed the fix_segfault branch 3 times, most recently from 9b7dc2d to 4d2b56f Compare February 17, 2026 05:31
@amarnath-ac amarnath-ac marked this pull request as ready for review February 18, 2026 05:49
…ection (#776)

1. Initialize APF session timer to prevent nil pointer dereference
   during CIRA connection cleanup.
2. Replace direct CIM.Chip.Get() calls with Enumerate+Pull pattern to handle
   empty/malformed chip data gracefully and prevent connection termination.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments