Open
Conversation
Nomafin
suggested changes
Nov 11, 2019
Comment on lines
+669
to
+671
| // Get request uri safely. | ||
| $request_uri = filter_var( $_SERVER['REQUEST_URI'], FILTER_SANITIZE_URL ); | ||
| $permalink = $this->dp_get_home_url() . $request_uri; |
Contributor
There was a problem hiding this comment.
Wouldn't this create problems in installs that are not done on the root of a domain? If the home url was https://www.domain.com/subfolder and $request_uri was /subfolder/some-page this method would return https://www.domain.com/subfolder/subfolder/some-page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes permalink data on WP object in archive views.
Tested on WPML and Polylang.