Feature/admin forth/1137/lets remove heavy debug and in #445

yaroslav8765 · 2026-01-09T12:14:43Z

No description provided.

…ector, and socketBroker modules

…cross components

Copilot

Pull request overview

This PR modernizes the logging infrastructure by replacing scattered console.log, console.error, and environment-based debug statements with a structured logging system using pino and pino-pretty. The implementation introduces three logger instances (logger, afLogger, dbLogger) for different logging contexts, each configurable via environment variables.

Changes:

Introduced centralized logging module using pino with three distinct loggers for user logs, AdminForth internal logs, and database query logs
Replaced console.log/console.error and process.env.HEAVY_DEBUG && console.log() patterns with appropriate logger calls throughout the codebase
Added pino and pino-pretty dependencies to package.json
Updated documentation and templates to use the new logger

Reviewed changes

Copilot reviewed 37 out of 38 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
adminforth/modules/logger.ts	New centralized logging module with three logger instances
adminforth/package.json	Added pino and pino-pretty dependencies
adminforth/servers/express.ts	Replaced console.log with afLogger calls
adminforth/modules/socketBroker.ts	Converted debug logs to afLogger.trace
adminforth/modules/restApi.ts	Replaced console.log with afLogger calls
adminforth/modules/codeInjector.ts	Converted debug and info logs to afLogger
adminforth/index.ts	Exported logger and replaced console.log with afLogger
adminforth/dataConnectors/*.ts	Replaced database debug logs with dbLogger
dev-demo/resources/*.ts	Updated to use logger from adminforth
dev-demo/index.ts	Replaced console.log with logger calls
adminforth/spa/src/components/*.vue	Removed commented-out console.log statements
adminforth/documentation/*/.md	Updated examples to use logger
adminforth/commands/*/.js	Replaced console.log with afLogger calls

Files not reviewed (1)

adminforth/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

adminforth/commands/postinstall.js

adminforth/modules/logger.ts

adminforth/servers/express.ts

adminforth/dataConnectors/postgres.ts

adminforth/index.ts

adminforth/dataConnectors/mongo.ts

adminforth/modules/codeInjector.ts

adminforth/commands/createApp/templates/adminuser.ts.hbs

adminforth/commands/callTsProxy.js

adminforth/commands/createCustomComponent/fileGenerator.js

…stent logging across modules

Copilot

Pull request overview

Copilot reviewed 40 out of 41 changed files in this pull request and generated 9 comments.

Files not reviewed (1)

adminforth/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

adminforth/commands/createCustomComponent/configLoader.js

adminforth/commands/createApp/utils.js

adminforth/commands/callTsProxy.js

adminforth/commands/createCustomComponent/configUpdater.js

adminforth/modules/socketBroker.ts

adminforth/servers/express.ts

dev-demo/resources/carsResourseTemplate.ts

adminforth/commands/createCustomComponent/main.js

adminforth/commands/createCustomComponent/fileGenerator.js

Copilot

Pull request overview

Copilot reviewed 40 out of 41 changed files in this pull request and generated 2 comments.

Files not reviewed (1)

adminforth/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

adminforth/modules/logger.ts

adminforth/index.ts

Copilot

Pull request overview

Copilot reviewed 32 out of 33 changed files in this pull request and generated 10 comments.

Files not reviewed (1)

adminforth/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-12T17:11:07Z

adminforth/modules/logger.ts

+
+export const afLogger = baseLogger.child(
+  { layer: 'af' },
+  { level: process.env.HEAVY_DEBUG ? 'trace' :  ( process.env.AF_DEBUG_LEVEL || 'info' ) }


There's an extra space before the opening parenthesis in line 22. This is inconsistent with lines 17 and 27. Consider removing the extra space for consistency.

Suggested change

{ level: process.env.HEAVY_DEBUG ? 'trace' : ( process.env.AF_DEBUG_LEVEL || 'info' ) }

{ level: process.env.HEAVY_DEBUG ? 'trace' : ( process.env.AF_DEBUG_LEVEL || 'info' ) }

Copilot · 2026-01-12T17:11:07Z

adminforth/modules/restApi.ts

-  if (process.env.HEAVY_DEBUG) {
-    console.log('🪲Interpreting resource', resource.resourceId, source, 'adminUser', adminUser);
-  }
+  afLogger.trace(`🪲Interpreting resource, ${resource.resourceId}, ${source}, 'adminUser', ${adminUser}`);


The adminUser object is being directly interpolated into the log message without JSON.stringify. This will result in [object Object] being logged. Consider using ${JSON.stringify(adminUser)} or logging specific properties like ${adminUser.username} for better log readability.

Suggested change

afLogger.trace(`🪲Interpreting resource, ${resource.resourceId}, ${source}, 'adminUser', ${adminUser}`);

afLogger.trace(`🪲Interpreting resource, ${resource.resourceId}, ${source}, 'adminUser', ${JSON.stringify(adminUser)}`);

Copilot · 2026-01-12T17:11:08Z

adminforth/modules/restApi.ts

            type: AdminForthDataTypes.STRING,
          });
-          console.log('Adding passwordHashField to userResource', userResource)
+          afLogger.info(`Adding passwordHashField to userResource, ${userResource}`);


The userResource object is being directly interpolated into the log message without JSON.stringify. This will result in [object Object] being logged. Consider using ${JSON.stringify(userResource)} or logging specific properties like ${userResource.resourceId} for better log readability.

Suggested change

afLogger.info(`Adding passwordHashField to userResource, ${userResource}`);

afLogger.info(`Adding passwordHashField to userResource, resourceId=${userResource.resourceId}`);

Copilot · 2026-01-12T17:11:08Z

adminforth/index.ts

    // execute hook if needed
    for (const hook of listify(resource.hooks?.create?.beforeSave)) {
-      console.log('🪲 Hook beforeSave', hook);
+      afLogger.debug(`🪲 Hook beforeSave ${hook}`);


The hook function object is being directly interpolated into the log message without proper conversion. This will result in [Function: functionName] or similar being logged. Consider logging ${hook.name} if you want the function name, or removing it if the message is sufficient without it.

Copilot · 2026-01-12T17:11:08Z

adminforth/modules/logger.ts

+export const logger = baseLogger.child(
+  { layer: 'user_logs' },
+  { level: process.env.HEAVY_DEBUG ? 'trace' : ( process.env.DEBUG_LEVEL || 'info' ) }
+);
+
+export const afLogger = baseLogger.child(
+  { layer: 'af' },
+  { level: process.env.HEAVY_DEBUG ? 'trace' :  ( process.env.AF_DEBUG_LEVEL || 'info' ) }
+);
+
+export const dbLogger = baseLogger.child(
+  { layer: 'db' },
+  { level: process.env.HEAVY_DEBUG_QUERY ? 'trace' : (process.env.DB_DEBUG_LEVEL|| 'info') }
+);


The logger children are configured with a level option in the second parameter, but pino's child method expects the level to be part of the first parameter (the bindings object). The current configuration will not set the log level correctly. The level should be moved to the first parameter or set separately using a different approach.

Suggested change

export const logger = baseLogger.child(

{ layer: 'user_logs' },

{ level: process.env.HEAVY_DEBUG ? 'trace' : ( process.env.DEBUG_LEVEL || 'info' ) }

);

export const afLogger = baseLogger.child(

{ layer: 'af' },

{ level: process.env.HEAVY_DEBUG ? 'trace' : ( process.env.AF_DEBUG_LEVEL || 'info' ) }

);

export const dbLogger = baseLogger.child(

{ layer: 'db' },

{ level: process.env.HEAVY_DEBUG_QUERY ? 'trace' : (process.env.DB_DEBUG_LEVEL|| 'info') }

);

export const logger = baseLogger.child({

layer: 'user_logs',

level: process.env.HEAVY_DEBUG ? 'trace' : ( process.env.DEBUG_LEVEL || 'info' ),

});

export const afLogger = baseLogger.child({

layer: 'af',

level: process.env.HEAVY_DEBUG ? 'trace' : ( process.env.AF_DEBUG_LEVEL || 'info' ),

});

export const dbLogger = baseLogger.child({

layer: 'db',

level: process.env.HEAVY_DEBUG_QUERY ? 'trace' : (process.env.DB_DEBUG_LEVEL|| 'info'),

});

Copilot · 2026-01-12T17:11:09Z

adminforth/servers/express.ts

      }
      this.expressApp.get(`${slashedPrefix}assets/*`, handler);
-      process.env.HEAVY_DEBUG && console.log('®️ Registering SPA serve handler', `${slashedPrefix}assets/*`);
+      afLogger.trace(`®️ Registering SPA serve handler', ${slashedPrefix}assets/*`);


There's a mismatched quote in the template literal. The string starts with a backtick and contains a single quote that should be removed or the template literal should be properly closed. The correct format should be: ®️ Registering SPA serve handler, ${slashedPrefix}assets/* (removing the single quote after 'handler').

Suggested change

afLogger.trace(`®️ Registering SPA serve handler', ${slashedPrefix}assets/*`);

afLogger.trace(`®️ Registering SPA serve handler, ${slashedPrefix}assets/*`);

Copilot · 2026-01-12T17:11:09Z

adminforth/modules/socketBroker.ts

      if (filterUsers) {
        if (! (await filterUsers(client.adminUser)) ) {
-          process.env.HEAVY_DEBUG && console.log('Client not authorized to receive message', topic, client.adminUser);
+          afLogger.trace(`Client not authorized to receive message ${topic} ${client.adminUser}`);


The client.adminUser object is being directly interpolated into the log message without JSON.stringify. This will result in [object Object] being logged. Consider using ${JSON.stringify(client.adminUser)} or logging specific properties like ${client.adminUser.username} for better log readability.

Suggested change

afLogger.trace(`Client not authorized to receive message ${topic} ${client.adminUser}`);

afLogger.trace(`Client not authorized to receive message ${topic} ${JSON.stringify(client.adminUser)}`);

Copilot · 2026-01-12T17:11:10Z

adminforth/documentation/docs/tutorial/03-Customization/16-websocket.md

 ```javascript
 import websocket from '@/websocket';
+import { logger } from 'adminforth'

 websocket.subscribe('/topic-name', (data) => {
  // this callback called when we receive publish in topic from the websocket
-  console.log(data);
+  logger.info(data);


The logger import import { logger } from 'adminforth' is shown in a frontend JavaScript context (subscribing to websocket in a Vue component). However, the logger is a backend-only module using pino, which won't work in the browser. If logging is needed in frontend code, consider using console.log or a browser-compatible logging solution. Remove this import from the frontend example.

Copilot · 2026-01-12T17:11:10Z

adminforth/index.ts

    // execute hook if needed
    for (const hook of listify(resource.hooks?.create?.afterSave)) {
-      process.env.HEAVY_DEBUG && console.log('🪲 Hook afterSave', hook);
+      afLogger.trace(`🪲 Hook afterSave ${hook}`);


The hook function object is being directly interpolated into the log message without proper conversion. This will result in [Function: functionName] or similar being logged. Consider logging ${hook.name} if you want the function name, or removing it if the message is sufficient without it.

Suggested change

afLogger.trace(`🪲 Hook afterSave ${hook}`);

afLogger.trace(`🪲 Hook afterSave ${hook.name || 'anonymous'}`);

yaroslav8765 added 7 commits January 9, 2026 14:13

feat: add pino logger

11efdf3

chore: update db logs to support pino logger

cc90b21

chore: use logge instead of HEAVY_DEBUG

6b0d3bb

chore: enhance logging messages for clarity in baseConnector, codeInj…

b7b70f6

…ector, and socketBroker modules

fix: correct import path for afLogger in proxy.ts

9541c4d

chore: replace console logging with afLogger for consistent logging a…

7b1718b

…cross components

chore: use logger instead of console.log

c3ae78b

yaroslav8765 requested a review from Copilot January 10, 2026 12:53

Copilot started reviewing on behalf of yaroslav8765 January 10, 2026 12:54 View session

Copilot AI reviewed Jan 10, 2026

View reviewed changes

yaroslav8765 added 4 commits January 12, 2026 10:59

chore: replace console.error and console.warn with afLogger for consi…

b1a391f

…stent logging across modules

fix: rebuild

2c0f744

fix: rebuild

d5d641b

chore: resolve copilot review comments

5419fa9

yaroslav8765 requested a review from Copilot January 12, 2026 09:15

Copilot started reviewing on behalf of yaroslav8765 January 12, 2026 09:15 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

chore: resolve copilot review comments[2]

84a02a1

yaroslav8765 requested a review from Copilot January 12, 2026 09:28

Copilot started reviewing on behalf of yaroslav8765 January 12, 2026 09:29 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

adminforth/modules/logger.ts Show resolved Hide resolved

adminforth/index.ts Show resolved Hide resolved

yaroslav8765 added 2 commits January 12, 2026 11:36

chore: revert afLogger updates for the commands

a66db2a

chore: update createApp templates

383c5f4

yaroslav8765 requested a review from Copilot January 12, 2026 17:05

Copilot started reviewing on behalf of yaroslav8765 January 12, 2026 17:06 View session

Copilot AI reviewed Jan 12, 2026

View reviewed changes

	{ level: process.env.HEAVY_DEBUG ? 'trace' : ( process.env.AF_DEBUG_LEVEL \|\| 'info' ) }
	{ level: process.env.HEAVY_DEBUG ? 'trace' : ( process.env.AF_DEBUG_LEVEL \|\| 'info' ) }

	afLogger.trace(`🪲Interpreting resource, ${resource.resourceId}, ${source}, 'adminUser', ${adminUser}`);
	afLogger.trace(`🪲Interpreting resource, ${resource.resourceId}, ${source}, 'adminUser', ${JSON.stringify(adminUser)}`);

	afLogger.info(`Adding passwordHashField to userResource, ${userResource}`);
	afLogger.info(`Adding passwordHashField to userResource, resourceId=${userResource.resourceId}`);

	afLogger.trace(`®️ Registering SPA serve handler', ${slashedPrefix}assets/*`);
	afLogger.trace(`®️ Registering SPA serve handler, ${slashedPrefix}assets/*`);

	afLogger.trace(`Client not authorized to receive message ${topic} ${client.adminUser}`);
	afLogger.trace(`Client not authorized to receive message ${topic} ${JSON.stringify(client.adminUser)}`);

	afLogger.trace(`🪲 Hook afterSave ${hook}`);
	afLogger.trace(`🪲 Hook afterSave ${hook.name \|\| 'anonymous'}`);

Feature/admin forth/1137/lets remove heavy debug and in #445

Are you sure you want to change the base?

Feature/admin forth/1137/lets remove heavy debug and in #445

Uh oh!

Conversation

yaroslav8765 commented Jan 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants