Conversation
Dockerfile
Outdated
|
|
||
| # Build the manager binary | ||
| FROM registry.access.redhat.com/ubi9/go-toolset:1.22.9@sha256:e4193e71ea9f2e2504f6b4ee93cadef0fe5d7b37bba57484f4d4229801a7c063 as builder | ||
| FROM registry.redhat.io/ubi9/go-toolset:1.24.4-1753853351@sha256:0d87cff818d4494b9d93c0d02a5de2d148ceab9c74aa836729ff5923b8d87feb as builder |
There was a problem hiding this comment.
Does changing from registry.access.redhat.com to registry.redhat.io change the way/permissions it needs to pull? Do you know?
There was a problem hiding this comment.
@Jdubrick I'm not too sure, but that's what it said on the webpage: https://catalog.redhat.com/software/containers/ubi9/go-toolset/61e5c00b4ec9945c18787690?container-tabs=gti
There was a problem hiding this comment.
That has the tokens, I think for now we should probably use the registry.access.redhat.com one to stay consistent with what it used to be, if we end up needing to change later if it gets deprecated or something we can address it then, IMO
There was a problem hiding this comment.
should be updated now!
There was a problem hiding this comment.
Oop somehow it didn't go through, just updated it! @Jdubrick @michael-valdron
michael-valdron
left a comment
michael-valdron
left a comment
There was a problem hiding this comment.
@JslYoon Looks good aside from the unchanged base image @Jdubrick mentioned, once this feedback is addressed, openshift/release#68063 is merged, and everything is still passing I will approve.
Dockerfile
Outdated
|
|
||
| # Build the manager binary | ||
| FROM registry.access.redhat.com/ubi9/go-toolset:1.22.9@sha256:e4193e71ea9f2e2504f6b4ee93cadef0fe5d7b37bba57484f4d4229801a7c063 as builder | ||
| FROM registry.redhat.io/ubi9/go-toolset:1.24.4-1753853351@sha256:0d87cff818d4494b9d93c0d02a5de2d148ceab9c74aa836729ff5923b8d87feb as builder |
Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
JslYoon
force-pushed
the
JslYoon/UpdateGo1.24
branch
from
ce647d4 to
7d8cacb
Compare
Jdubrick
left a comment
Jdubrick
left a comment
There was a problem hiding this comment.
lgtm, I would wait until @michael-valdron approves as well
|
/test all |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, JslYoon, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Description of Changes
Updated go version to 1.24, replaced required images
Related Issue(s)
devfile/api#1696
Acceptance Criteria
Tests
Documentation
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Running Unit Tests
Running Integration Tests
Notes To Reviewer
Any notes you would like to include for the reviewer.