Repair FeignClient: Use feign dependencies for okhttp/httpclient

[tfabien]

Use io.github.openfeign:feign-okhttp and io.github.openfeign:feign-httpclient instead of com.squareup.okhttp3:okhttp and org.apache.httpcomponents:httpclient
If not, Feign client won't use these clients and won't honor the feign.okhttp.enabled / feign.httpclient.enabled configuration (and fallback to sun httpClient, without using the proxy selector)

[deveth0]

hey, thanks for the PR!

Are you sure, those changes are sufficient, they only change the sample-project but not the starter / autoconfig:
https://github.com/deveth0/httpclient-spring-boot-starter/blob/develop/httpclient-spring-boot-autoconfigure/pom.xml
https://github.com/deveth0/httpclient-spring-boot-starter/blob/develop/httpclient-spring-boot-starter/pom.xml

[tfabien]

I'll update the httpclient-spring-boot-autoconfigure/pom.xml, keeping them optional
For httpclient-spring-boot-starter/pom.xml however, only httpclient is included at the moment, and it's not optional, should I include okhttpand make both optional?
Furthermore, shouldn't these dependencies only be declare in httpclient-spring-boot-autoconfigure ? (not familiar with the optional parameter, I don't know if I need to repeat these dependencies)

[deveth0]

interesting question, i'm 100% sure, if it's required to have those in starter, but given that the official starters also include depencendies (and the autoconfigs optional dependencies), I guess we should keep em ;)
https://github.com/spring-projects/spring-boot/blob/master/spring-boot-project/spring-boot-starters/spring-boot-starter-data-couchbase/build.gradle