add a map-compare widget to compare two lonboard maps by swiping#8
Merged
Conversation
Member
Do you have a screencast of the jitter? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Widget to compare two lonboard maps with a swipe / slider!
There's a little bit of jitter when panning the map inside Jupyterlab, which doesn't occur when exported statically. @kylebarron I can file an issue in
lonboardthat could help improve that, but the jitter is pretty minor and I think it's also fine.I was very keen to have this widget as it seems table stakes for map widgets - will be great to get any suggestions on how it can be improved - merging for now to get the example and demo live.
cc @wrynearson @dzole0311