Skip to content

Improve .gitmodules file handling in scan_content_warn #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xScratch wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve .gitmodules file handling in scan_content_warn #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sanitize_repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1902,8 +1902,10 @@ def _onerror(e: OSError) -> None:
elif nm == ".gitmodules":
# newline="" preserves \r so the CVE-2025-48384 CR vector is
# not silently translated to \n before _warn_gitmodules sees it
out += _warn_gitmodules(
rel, p.read_text(encoding="utf-8", errors="replace", newline=""))
with p.open(
"r", encoding="utf-8", errors="replace", newline=""
) as f:
out += _warn_gitmodules(rel, f.read())
elif nm == "nx.json":
out += _warn_nx(rel, json.loads(p.read_text(encoding="utf-8")))
elif nm == "turbo.json":
Expand Down