Dev container images info issue fix regarding history documentation and cgmanifest updates#1891
Open
Kaniska244 wants to merge 3 commits into
Open
Dev container images info issue fix regarding history documentation and cgmanifest updates#1891Kaniska244 wants to merge 3 commits into
Kaniska244 wants to merge 3 commits into
Conversation
Kaniska244
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the image metadata extraction and tag generation logic used by the dev container image build pipeline, with the goal of producing cleaner history documentation and more consistent component (cgmanifest.json) output.
Changes:
- Adjusts version-detection commands for several components (Yarn, Java 8, .NET host version).
- Deduplicates generated image tags while preserving order.
- Changes pip package info extraction to omit packages whose installed version cannot be determined, and updates image manifests (including removing
wheelfrom Universal).
Show a summary per file
| File | Description |
|---|---|
| src/universal/manifest.json | Removes wheel from the Universal image’s pip package list (and reflects the manifest version bump). |
| src/java-8/manifest.json | Bumps version and simplifies Java 8 version detection to avoid duplicate output. |
| src/dotnet/manifest.json | Bumps version and fixes host version parsing to support multi-digit segments. |
| build/src/utils/image-content-extractor.js | Updates pip package collection logic to skip entries without versions (needs a normalization fallback to avoid skipping valid packages). |
| build/src/utils/config.js | Deduplicates generated tags in tag construction helpers while preserving order. |
| build/config.json | Updates Yarn version command to suppress stderr and extract version values. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 1
Comment on lines
+274
to
+288
| return packageList.reduce((list, package) => { | ||
| const version = versionLookup[package]; | ||
| // Skip packages that aren't actually installed in the inspected environment. | ||
| // Emitting an entry without a version produces blank markdown rows and | ||
| // conflicting/duplicate cgmanifest.json (SBOM) registrations. | ||
| if (version) { | ||
| list.push({ | ||
| name: package, | ||
| version: version | ||
| }); | ||
| } else { | ||
| console.log(`(!) Warning: Could not determine version for pip package "${package}" - skipping.`); | ||
| } | ||
| return list; | ||
| }, []); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issues in dev container image metadata generation that affected history documentation and
cgmanifest.jsonoutput.The changes improve version extraction and prevent duplicate or invalid package/component entries from being generated.
Changes
cgmanifest.jsonentries.wheelfrom the Universal image Python package list.dotnet:2.1.1→2.1.2java-8:3.0.9→3.1.0universal:6.0.4→6.0.5Validation
These changes are intended to ensure generated image info, history documentation, and component manifest data are accurate, deduplicated, and do not include entries with missing versions.