update docker-compose version to latest and add new test scenarios#1571
update docker-compose version to latest and add new test scenarios#1571sireeshajonnalagadda wants to merge 8 commits intodevcontainers:mainfrom
Conversation
Kaniska244
left a comment
Kaniska244
left a comment
There was a problem hiding this comment.
The change as such looks fine. Left a few comments. Please let me know in case of any concern.
| { | ||
|
|
||
| "id": "docker-outside-of-docker", | ||
| "version": "1.8.0", |
There was a problem hiding this comment.
Please do a version bump.
There was a problem hiding this comment.
If this test script is duplicated from existing test scripts, can we please create a symlink to the original script instead of duplication?
There was a problem hiding this comment.
Added this test script for Docker Compose latest(5.x.x); retained unchanged as only version differs. Created symlink to align with existing 'latest' script."
There was a problem hiding this comment.
@sireeshajonnalagadda I don't see changes on this file though. Could you please convert this to symlink as well if its a duplicated copy.
There was a problem hiding this comment.
@Kaniska244
The checks are structurally identical, with the only difference being the regex used to validate Docker Compose version 5 instead of version 2. To avoid duplication, a symlink has been created from one of the 'latest' scripts to align with the other 'latest' script without Moby.
|
Hi @Kaniska244, |
There was a problem hiding this comment.
@sireeshajonnalagadda I don't see changes on this file though. Could you please convert this to symlink as well if its a duplicated copy.
2 participants
This PR fixes issue
Description of changes:
Updated the default value of dockerDashComposeVersion to latest to make use of the most recent features and security updates.
Added latest to the list of supported values for dockerDashComposeVersion in the devcontainer-feature.json Updated the Readme.md
added new tests and scenarios