fix: podman-compose build-arg handling#1248
Open
aidalgol wants to merge 1 commit into
Open
Conversation
getBuildInfoForService assumes build args are in the YAML map form, but podman compose config outputs build args in the YAML list form. Add a type check on composeBuild.args and convert it to key/value object if it's an array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing build args to a compose file is broken when using
podmanandpodman-compose.getBuildInfoForServiceassumes build args are in the YAML map form, butpodman compose configoutputs build args in the YAML list form. This adds a type check oncomposeBuild.argsand converts it to key/value object if it's an array.