Closed
Conversation
Implement keyframe generation logic that converts Figma's SMART_ANIMATE transitions to CSS keyframe animations. Features: - New keyframe.ts module with comprehensive keyframe generation functions - Enhanced getSelectorProps() with optional keyframe generation - generateKeyframeFromTransition() for single transition conversion - generateKeyframesForEffects() for multiple effect handling - Smart animation name generation based on effect and properties - Full unit test coverage (14 tests, 100% function coverage) - Comprehensive usage documentation in KEYFRAME_USAGE.md The feature is opt-in via useKeyframes option, maintaining backward compatibility with existing CSS transition behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement keyframe generation logic that converts Figma's SMART_ANIMATE
transitions to CSS keyframe animations.
Features:
The feature is opt-in via useKeyframes option, maintaining backward
compatibility with existing CSS transition behavior.