chore(skills): migrate mattpocock/skills to v1.1.0, pinned - #118
Merged
Conversation
Pin the vendored skill set to the v1.1.0 release tag (was an unpinned pre-1.0 snapshot from 2026-05-17, tracking the default branch implicitly). skills-lock.json now records ref: v1.1.0 for every entry, so the installed state is auditable from the file rather than from git archaeology. Follow the four upstream renames — diagnose to diagnosing-bugs, to-prd to to-spec, to-issues to to-tickets (merged with to-plan), write-a-skill to writing-great-skills — and drop caveman and zoom-out, both deleted upstream with no successor. v1.1.0 refactored the set into a dependency graph: grill-me, grill-with-docs, triage and improve-codebase-architecture became thin shells that delegate to grilling, domain-modeling and codebase-design, so those three are required, not optional. CONTEXT-FORMAT.md and ADR-FORMAT.md moved from grill-with-docs to domain-modeling. Take the full promoted set (engineering/ + productivity/), which adds ask-matt, code-review, implement, research, resolving-merge-conflicts, teach and wayfinder. Skills now live directly in .claude/skills/ instead of .agents/skills/ with symlinks. The CLI copies into the agent directory when a single agent is targeted and only uses the shared .agents/ store when installing for two or more, so the old layout was an artifact of the original install, not a choice worth preserving. ADR-0021 is unaffected: it treats both as equivalent discovery locations, and the separation it protects is skills/ (authored for publication) versus vendored, which is intact. Six dead entries were purged from skills-lock.json by hand: `skills remove` deletes the files but leaves the lock entries, and then no longer recognises them.
Bring docs/agents/ up to the v1.1.0 templates. issue-tracker.md gains two additive sections — "Pull requests as a triage surface" (flag left at `no`) and "Wayfinding operations" for /wayfinder. domain.md now names /domain-modeling, not /grill-with-docs, as the producer of CONTEXT.md and ADRs. triage-labels.md was already identical. External PRs stay off as a triage surface: of 54 non-owner PRs on this repo, all but one are dependabot or github-actions, and the template's authorAssociation filter doesn't exclude bots. Turning it on would feed ~50 dependency bumps into /triage to catch roughly one human PR a quarter. Record that this repo's CONTEXT.md keeps three sections the upstream glossary format dropped — Relationships, Example dialogue, Flagged ambiguities — and that they must be maintained alongside ## Language. They hold live knowledge (the Example dialogue was corrected two commits ago in 52cfced), so the deviation is deliberate and now explicit rather than silent. Add ADR-0023 for the delivery mechanism: vendored and pinned to a release tag, over the Claude Code plugin upstream now ships.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the vendored agent skills from an unpinned pre-1.0 snapshot (2026-05-17) to the v1.1.0 release tag, and pins them so the installed state is recorded in
skills-lock.jsoninstead of inferable only from git archaeology.Why this isn't a
skills updateskills updatematches by name. Upstream renamed four skills, deleted two, and refactored the rest into a dependency graph — so an update would have refreshed the survivors and silently left six orphans behind. There was never reliable automatic updating here, only silent drift.diagnose→diagnosing-bugs,to-prd→to-spec,to-issues→to-tickets(merged withto-plan),write-a-skill→writing-great-skillscaveman,zoom-out— dropped, no successorgrilling,domain-modeling,codebase-designask-matt,code-review,implement,research,resolving-merge-conflicts,teach,wayfinderv1.1.0 turned
grill-me,grill-with-docs,triageandimprove-codebase-architectureinto thin shells that delegate togrilling,domain-modelingandcodebase-design, so those three aren't optional — without them four skills invoke something that doesn't exist.CONTEXT-FORMAT.mdandADR-FORMAT.mdmoved fromgrill-with-docstodomain-modeling.The set is upstream's promoted bucket (
engineering/+productivity/, 22 skills) pluscrafting-effective-readmesfromsoftaworks/agent-toolkit.-s '*'would have pulled 37, including Matt's personal Obsidian and course tooling, andsetup-pre-commit, which installs Husky + lint-staged + Prettier over this repo's lefthook + biome.Layout change
Skills now live directly in
.claude/skills/rather than.agents/skills/with symlinks. The CLI copies into the agent directory when a single agent is targeted and only uses the shared.agents/store for two or more, so the old layout was an artifact of how the first install ran, not a choice..agents/is gone.ADR-0021 is unaffected — it treats
.agents/skills/and.claude/skills/as equivalent discovery locations, and the separation it protects (skills/= authored for publication) is intact.Repo config
docs/agents/issue-tracker.mdgains the two additive v1.1.0 sections: Pull requests as a triage surface and Wayfinding operations.authorAssociationfilter doesn't exclude bots — turning it on feeds ~50 dependency bumps into/triageto catch about one human PR a quarter.docs/agents/domain.mdnames/domain-modelingas the producer ofCONTEXT.mdand ADRs, and now records that this repo'sCONTEXT.mdkeeps three sections the upstream glossary format dropped (## Relationships,## Example dialogue,## Flagged ambiguities). They hold live knowledge — the Example dialogue was corrected two commits ago in 52cfced — so the deviation is deliberate, and declaring it keepsdomain-modelingfrom letting them rot.Verification
SKILL.mdfiles hash-matchmattpocock/skills@v1.1.0byte for byte.skills-lock.jsonand.claude/skills/agree exactly: 23 entries, no orphans, no symlinks,ref: v1.1.0on all 22 (crafting-effective-readmesis a different source and stays unpinned, as before).Two things worth knowing
skills updatea no-op. Upgrading is now a manual bump: read the release notes, change the tag, re-runadd. That's the trade — and this migration is the argument for it, since the notes are where renames and deletions get announced.skills removedoesn't purge lock entries. It deletes the files, then stops recognising the names. The six dead entries were removed fromskills-lock.jsonby hand.One known defect carried over verbatim from the upstream template: the PR-triage recipe uses
gh pr list --json …,authorAssociation, which isn't a valid field forgh pr list(it only exists viagh api). Dead text while the flag isno— needs fixing before anyone turns it on.