feat(webapp): replace dependency vue-timeago#745
Merged
peterthomassen merged 2 commits intodesec-io:mainfrom Jun 27, 2023
Merged
feat(webapp): replace dependency vue-timeago#745peterthomassen merged 2 commits intodesec-io:mainfrom
vue-timeago#745peterthomassen merged 2 commits intodesec-io:mainfrom
Conversation
No need for an extra wrapper as dependency.
peterthomassen
approved these changes
Jun 27, 2023
Member
peterthomassen
left a comment
peterthomassen
left a comment
There was a problem hiding this comment.
thank you very much - lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As @lukaslihotzki mentioned in #699 the dependency
javascript-time-agois not used.The time ago component
vue-timeagois a wrapper fordate-fns. The component is just used once and limited functionality so it could be implement very easy. This simplifies the dependency graph and for the migration to vue3 there is no need for replacement.