fix(www): middle click on agreement links#697
Merged
peterthomassen merged 1 commit intodesec-io:mainfrom Mar 7, 2023
Merged
Conversation
peterthomassen
approved these changes
Mar 7, 2023
Member
peterthomassen
left a comment
peterthomassen
left a comment
There was a problem hiding this comment.
Thanks, just one minor question. Otherwise lgtm!
peterthomassen
force-pushed
the
target_blank
branch
from
c1ed9e3 to
e26ea66
Compare
peterthomassen
force-pushed
the
target_blank
branch
from
e26ea66 to
594efb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes middle click on agreement links (to open it in a new tab without switching). It also fixes the validation error showing up when just clicking on a link. Furthermore, it makes the code more consistent (use
router-linkeverywhere instead of$router.resolve, usetarget="_blank"everywhere instead ofwindow.open).