Skip to content

feat: populate jwt_response.claims#652

Closed
ckiee wants to merge 1 commit intomainfrom
mei/jwtresp-claims
Closed

feat: populate jwt_response.claims#652
ckiee wants to merge 1 commit intomainfrom
mei/jwtresp-claims

Conversation

@ckiee
Copy link
Copy Markdown
Member

@ckiee ckiee commented Sep 11, 2025

Related Issues

Part-of: https://github.com/descope/etc/issues/11910

Honestly this feels extraneous with the adjacent sessionToken being a dict with the claims in a non-cookie environment, but it doesn't hurt to be consistent across SDKs.

Must

  • Tests
  • Documentation (if applicable)

@ckiee ckiee requested review from asafshen and Copilot September 11, 2025 09:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds population of the claims field to JWT responses to maintain consistency across SDKs. The change extracts claims from the response body and includes them in the JWT response object.

  • Adds claims field extraction from response body to JWT response generation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link
Copy Markdown

Coverage report

The coverage rate went from 97.79% to 97.79% ⬆️

100% of new lines are covered.

Diff Coverage details (click to unfold)

descope/auth.py

100% of new lines are covered (95.67% of the complete file).

@ckiee
Copy link
Copy Markdown
Member Author

ckiee commented Sep 11, 2025

descope/go-sdk#605 (comment)

Not necessary after discussion since the backend will always have the session token and we'd rather protect the user from data inconsistency, then make getting the claims a bit shorter.

@ckiee ckiee closed this Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants