Release v1.4.0#287
Merged
Merged
Conversation
Bump version to 1.4.0, date the release log entry, and sync CITATION.cff. Also fixes AGENTS.md drift caught during the release readiness check: TupleManager/RegexTupleManager.__getattr__'s unknown-key description was stale after #256 added a deprecation warning there, and the new _EmptyAttributeDefaultAttribute descriptor (#255) and its inspect.getattr_static requirement in __getstate__/__setstate__ were undocumented. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #287 +/- ##
=======================================
Coverage 97.67% 97.67%
=======================================
Files 13 13
Lines 947 947
=======================================
Hits 925 925
Misses 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Version bump for the v1.4 milestone (4/4 issues closed: #260, #262, #263, #265):
VERSIONto(1, 4, 0)innameparser/_version.pyCITATION.cff'sversion:field to match (it had drifted since 1.3.0 -- the 1.3.1 patch release didn't touch it)docs/release_log.rst's1.4.0 - Unreleasedheader with today's dateAlso included: AGENTS.md staleness fixes
Caught during the pre-release doc review (step 0 of the release checklist):
TupleManager/RegexTupleManager.__getattr__'s description said it "answer[s] any unknown attribute lookup" -- no longer accurate since TupleManager unknown-key access silently returns None / EMPTY_REGEX; raise AttributeError in 2.0 #256 added aDeprecationWarningon unknown-key access. Corrected, and documented the warning's dunder/sunder exclusions plus the consequence that internal parser code readingself.C.regexes.<key>unconditionally now warns against partial customregexesoverrides._EmptyAttributeDefaultAttributedescriptor (Remove empty_attribute_default; empty attributes always return '' #255) wasn't documented alongside the existing_SetManagerAttribute/_CachedUnionMemberdescriptors -- added, including why__get__(obj=None)returns''instead ofself(load-bearing forConstants.__repr__, not just mypy) and why__getstate__/__setstate__needinspect.getattr_staticinstead of plaingetattrto detect it.Test plan
python -c "from nameparser import __version__; print(__version__)"→1.4.0🤖 Generated with Claude Code