feat(http): stabilize Problem Details - #7270
Open
tomas-zijdemans wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7270 +/- ##
==========================================
- Coverage 95.03% 95.03% -0.01%
==========================================
Files 618 617 -1
Lines 51596 51593 -3
Branches 9340 9340
==========================================
- Hits 49035 49031 -4
Misses 2021 2021
- Partials 540 541 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stabilizes
@std/http/problem-details, the RFC 9457 Problem Details module. It has been unstable since #7033 (March 2026), was reshaped once in #7117, and has sat untouched since: no open issues, no bug reports, 38 tests.Changes
http/unstable_problem_details.tstohttp/problem_details.ts(test file too) and moves the export to@std/http/problem-details@experimentaltagshttp/mod.tsand adds a short Problem Details section to the package docisProblemDetailsResponsedoc: it claimed "type guard" but the function returns a plainbooleanTwo behaviors that freeze at 1.x
Both are deliberate and documented. Flagging them here so they get a look now rather than in an issue later:
parseProblemDetailsthrowsTypeErroron aResponse. AResponseis a non-null, non-array object with no enumerable own keys, so it would otherwise parse silently to an empty object. The error points callers atparseProblemDetailsResponse.parseProblemDetailsResponseparses any JSON body without checking the content type. Detection belongs toisProblemDetailsResponse, so the pair composes without checking twice.