BREAKING(cache/unstable): remove LruCache and TtlCache - #7265
Open
tomas-zijdemans wants to merge 2 commits into
Open
BREAKING(cache/unstable): remove LruCache and TtlCache#7265tomas-zijdemans wants to merge 2 commits into
LruCache and TtlCache#7265tomas-zijdemans wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7265 +/- ##
==========================================
- Coverage 95.03% 95.01% -0.03%
==========================================
Files 618 615 -3
Lines 51596 51372 -224
Branches 9340 9285 -55
==========================================
- Hits 49035 48811 -224
Misses 2021 2021
Partials 540 540 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First half of the split requested in the #7236 review: the removals land on their own, ahead of the unified
Cache, so each half is reviewable and revertible separately.Removes
LruCacheandTtlCachewith their tests and the./lru-cache/./ttl-cacheexport paths, and drops theLruCachereferences from thememoizedocs and tests.MemoizationCacheis untouched. Rationale and discussion live in #7236.