Extract AbstractAuthenticationService to share logic between jira and confluence#477
Merged
Merged
Conversation
… confluence The shared service plumbing (bulk set with declarative null-model and map-key fallback semantics, single-entity set, find-by-name, get/set SSO) lives in a new AbstractAuthenticationService in commons. Host-specific subclasses provide abstract hooks that delegate to their existing per-host model utils. Add tests for the null-model and null-name semantics in both AuthenticationServiceTests.
|
There was a problem hiding this comment.
Pull request overview
This PR extracts shared authentication IdP/SSO service logic into a new AbstractAuthenticationService in commons, allowing Jira and Confluence implementations to reuse the same bulk/set/find plumbing while delegating host-specific model conversions to abstract hooks.
Changes:
- Introduced
AbstractAuthenticationServiceincommonsto centralize IdP and SSO get/set behaviors. - Updated Jira and Confluence
AuthenticationServiceImplclasses to extend the new abstract service and provide conversion hook implementations. - Added new tests in both Jira and Confluence to cover map-key fallback for null IdP names and declarative null-model semantics.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
commons/src/main/java/com/deftdevs/bootstrapi/commons/service/AbstractAuthenticationService.java |
New shared base service implementing common IdP/SSO operations and bulk semantics. |
jira/src/main/java/com/deftdevs/bootstrapi/jira/service/AuthenticationServiceImpl.java |
Refactored to extend the new abstract service and provide Jira-specific conversions. |
confluence/src/main/java/com/deftdevs/bootstrapi/confluence/service/AuthenticationServiceImpl.java |
Refactored to extend the new abstract service and provide Confluence-specific conversions. |
jira/src/test/java/com/deftdevs/bootstrapi/jira/service/AuthenticationServiceTest.java |
Added tests for null-model and null-name (map key fallback) semantics. |
confluence/src/test/java/com/deftdevs/bootstrapi/confluence/service/AuthenticationServiceTest.java |
Added tests for null-model and null-name (map key fallback) semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Copilot stopped work on behalf of
pathob due to an error
May 13, 2026 15:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared service plumbing (bulk set with declarative null-model and map-key fallback semantics, single-entity set, find-by-name, get/set SSO) lives in a new AbstractAuthenticationService in commons. Host-specific subclasses provide abstract hooks that delegate to their existing per-host model utils.
Add tests for the null-model and null-name semantics in both AuthenticationServiceTests.