Add fetch options support via execute options bag#207
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for passing fetch options to the Narou API client by introducing an ExecuteOptions bag pattern that propagates through all API execution methods.
Key Changes:
- Introduced
ExecuteOptionstype containing optionalfetchOptions(RequestInit) - Updated all
execute()method signatures across builders and client methods to accept optionalExecuteOptions - Added test coverage for fetch options forwarding in the fetch implementation
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/narou.ts |
Defined ExecuteOptions type and updated abstract execute() signature and all public API methods to accept options parameter |
src/narou-fetch.ts |
Updated execute() to forward fetchOptions to the fetch call |
src/narou-jsonp.ts |
Added options parameter with underscore prefix to indicate it's intentionally unused (JSONP doesn't support fetch options) |
src/search-builder.ts |
Updated NovelSearchBuilderBase.execute() to accept and forward options |
src/search-builder-r18.ts |
Updated SearchBuilderR18.execute() to accept and forward options |
src/user-search.ts |
Updated UserSearchBuilder.execute() to accept and forward options |
src/ranking.ts |
Updated all execute() and executeWithFields() signatures to accept and forward options through the execution chain |
src/index.common.ts |
Exported ExecuteOptions type for public API consumers |
test/narou-fetch.test.ts |
Added test case verifying fetch options are correctly passed to the fetch implementation |
The implementation is clean and consistent across the codebase. The use of an options bag pattern provides good extensibility for future enhancements. The JSONP implementation appropriately ignores the options parameter since JSONP doesn't support custom fetch options.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Codex Task