Fix WarmupCosineLR multi-group initialization#7969
Merged
delock merged 1 commit intodeepspeedai:masterfrom Apr 12, 2026
Merged
Conversation
Signed-off-by: Masahiro Tanaka <mtanaka@anyscale.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WarmupCosineLRreturned a singleton pre-start LR list even when the optimizer had multiple parameter groups. Because scheduler initialization applies LRs withzip(param_groups, lrs), only group 0 was updated and later groups kept their base LR before the first optimizer step.The fix changes the pre-start scheduler outputs to match the multi-group contract by returning scalar
0.0fromget_lr_ratio()and a zero-filled LR list sized toself.org_lrs.