Skip to content

chore!: remove HF API components (moved to integrations)#11516

Open
anakin87 wants to merge 2 commits into
v3from
remove-hfapi-components
Open

chore!: remove HF API components (moved to integrations)#11516
anakin87 wants to merge 2 commits into
v3from
remove-hfapi-components

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Jun 4, 2026

Related Issues

Proposed Changes:

How did you test it?

CI

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Jun 4, 2026 4:53pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 4, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/components/embedders
  __init__.py
  haystack/utils
  hf.py
Project Total  

This report was generated by python-coverage-comment-action

@anakin87 anakin87 changed the title chore: remove HF API components (moved to integrations) chore!: remove HF API components (moved to integrations) Jun 4, 2026
assert combined in original or original in combined

@pytest.mark.asyncio
@pytest.mark.skipif(
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this file, there were several async integration tests skipped.
I replaced HuggingFaceAPIDocumentEmbedder with OpenAIDocumentEmbedder and I now run them (they don't take long).

@anakin87 anakin87 marked this pull request as ready for review June 4, 2026 16:57
@anakin87 anakin87 requested review from a team as code owners June 4, 2026 16:57
@anakin87 anakin87 requested review from davidsbatista and removed request for a team June 4, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant