draft: add SkillStore abstraction#11480
Draft
tstadel wants to merge 15 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
sjrl
reviewed
Jun 2, 2026
Co-authored-by: Sebastian Husch Lee <10526848+sjrl@users.noreply.github.com>
Co-authored-by: Sebastian Husch Lee <10526848+sjrl@users.noreply.github.com>
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
Contributor
There was a problem hiding this comment.
Could you make a version of this SkillStore using a db (like the one to be used in platform) to make sure this protocol definition works for at least two different backends?
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
sjrl
reviewed
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.